-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{numlib}[GCC/9.3.0] AMD-LibM v3.6.0-4, AMD-RNG v2.2, AMD-SecureRNG v2.2 #11929
{numlib}[GCC/9.3.0] AMD-LibM v3.6.0-4, AMD-RNG v2.2, AMD-SecureRNG v2.2 #11929
Conversation
…3.0.eb, AMD-SecureRNG-2.2-GCC-9.3.0.eb
Test report by @SebastianAchilles |
@boegelbot please test @ generoso |
Test report by @migueldiascosta |
@migueldiascosta: Request for testing this PR well received on generoso PR test command '
Test results coming soon (I hope)... - notification for comment with ID 750629714 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Going in, thanks @SebastianAchilles! |
toolchain = {'name': 'GCC', 'version': '9.3.0'} | ||
|
||
source_urls = ['http://developer.amd.com/wordpress/media/files/'] | ||
sources = ['aocl-rng-linux-gcc-%(version)s-4.tar.gz'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SebastianAchilles Shouldn't the -4
be part of the version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in #11934
toolchain = {'name': 'GCC', 'version': '9.3.0'} | ||
|
||
source_urls = ['http://developer.amd.com/wordpress/media/files/'] | ||
sources = ['aocl-securerng-linux-gcc-%(version)s-4.tar.gz'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, shouldn't -4
be part of the version (like it is for AMD-LibM
)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in #11935
|
||
sanity_check_paths = { | ||
'files': [], | ||
'dirs': ['lib'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be a bit more specific, a sanity check like this isn't very useful imho :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in #11935
(created using
eb --new-pr
)