Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix source URL in expat easyconfigs (and consistently add custom sanity_check_paths) #11960

Merged
merged 2 commits into from
Jan 6, 2021
Merged

fix source URL in expat easyconfigs (and consistently add custom sanity_check_paths) #11960

merged 2 commits into from
Jan 6, 2021

Conversation

boegel
Copy link
Member

@boegel boegel commented Jan 6, 2021 •
edited
Loading

(created using eb --new-pr)
fixes #11954

SHA256 checksums haven't changed, the expat source tarballs in my existing source archive all still work fine (full test report coming up).

@boegel boegel requested a review from verdurin January 6, 2021 14:26
@boegel boegel added the bug fix label Jan 6, 2021
@boegel boegel added this to the next release (4.3.3?) milestone Jan 6, 2021
@boegel
Copy link
Member Author

boegel commented Jan 6, 2021

Test report by @boegel
SUCCESS
Build succeeded for 19 out of 19 (19 easyconfigs in total)
node2608.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/95717d4ddc48cd0d537095eec8063f55 for a full test report.

@boegel boegel mentioned this pull request Jan 6, 2021
Closed
verdurin
verdurin approved these changes Jan 6, 2021
View reviewed changes
Copy link
Member

@verdurin verdurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@verdurin
Copy link
Member

verdurin commented Jan 6, 2021

Going in, thanks @boegel!

@verdurin verdurin merged commit 9fa20ee into easybuilders:develop Jan 6, 2021
@boegel boegel deleted the 20210106152501_new_pr_expat210 branch January 6, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@verdurin verdurin verdurin approved these changes

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
4.3.3
Development

Successfully merging this pull request may close these issues.

libexpat sources are no longer on sourceforge - moved to github
2 participants
@boegel @verdurin