-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate perl modules and add CI check #12575
base: develop
Are you sure you want to change the base?
Remove duplicate perl modules and add CI check #12575
Conversation
3b15181
to
a14aff5
Compare
@Flamefire: Tests failed in GitHub Actions, see https://github.com/easybuilders/easybuild-easyconfigs/actions/runs/744421481
bleep, bloop, I'm just a bot (boegelbot v20200716.01) |
Test report by @Flamefire |
Test report by @Flamefire |
Test report by @Flamefire |
Test report by @Flamefire |
Test report by @Flamefire |
Test report by @Flamefire |
Test report by @Flamefire |
Just to that I understand what's happening here: Do we need the alternative names for some stuff so thats why they are these redefined packages? |
Oh, sorry for the noise, test reports with In R ECs we have packages only by name. Those are supposed to be contained in the R base installation. Similar in Perl there seem to be packages which are part of other packages. The only reason why those are added again appears to be to make sure they exist by checking for them in the sanity check. So the change here is to NOT install those (which leads to installing the same package exactly the same way again), but only use their name so that is sanity checked. TLDR: Allow adding sanity checks for packages which are sub-packages of already installed packages (basically) |
Right. In some cases here, we don't actually have "sub" packages, but they are on the same level, like IO::Handle and friends under https://metacpan.org/release/IO I don't think many are intentionally added IO::File to be sure.. it's almost certainly just accidental because someone (like me) didn't know there wasn't a 1-to-1 mapping of module to source in Perl. Some of these also seem to be added despite them being part of Perl itself |
Similar to Python ECs we use the name to do some kind of If some of them are part of Perl we could still use this PR and in a follow-up "downgrade" them to the module name only, so they are checked for but not installed, similar to the R ECs. But that got to come from someone with more experience with Perl. This PR is good as a check for the EasyBlock change and future removals/changes can be based on this :) |
212a320
to
9754de0
Compare
Adds CI check for duplicate modules and sources. See an intentionally failing one at https://github.com/easybuilders/easybuild-easyconfigs/runs/2332539715