Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GenABEL to R-bundle-Bioconductor #12822

Conversation

verdurin
Copy link
Member

@verdurin verdurin commented May 5, 2021

(created using eb --new-pr)

@boegel
Copy link
Member

boegel commented May 5, 2021

@boegelbot please test @ generoso
EB_ARGS="--skip"

@boegel boegel added this to the next release (4.3.5?) milestone May 5, 2021
@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=12822 EB_ARGS="--skip" /apps/slurm/default/bin/sbatch --job-name test_PR_12822 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 17061

Test results coming soon (I hope)...

- notification for comment with ID 832977325 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
generoso-c1-s-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/3cef24e713230976424f35b06a00905b for a full test report.

@Micket
Copy link
Contributor

Micket commented May 7, 2021

Does order matter here?

ERROR: dependency GenABEL.data is not available for package GenABEL

@Micket
Copy link
Contributor

Micket commented May 7, 2021

@boegel How is this order dependency going to affect your changes to build extensions in parallel?

@lexming
Copy link
Contributor

lexming commented May 12, 2021

Test report by @lexming
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
node381.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/fcc79cfbf2824cc332433d104db8eb69 for a full test report.

@boegel
Copy link
Member

boegel commented May 12, 2021

@boegel How is this order dependency going to affect your changes to build extensions in parallel?

It won't. The order in exts_list is largely irrelevant when the R extensions are installed in parallel, because the installation of E is only started when the required extensions for E are installed already. See the required_deps method in easybuilders/easybuild-easyblocks#2408 (which should be reworked into a standalone function, so it can be unit tested and used by other easyblocks).

@boegel
Copy link
Member

boegel commented May 12, 2021

@lexming Any idea what caused this?

** byte-compile and prepare package for lazy loading
sh: line 1:  3339 Killed                  R_TESTS= '/user/brussel/101/vsc10122/.local/easybuild-skylake/software/R/4.0.3-foss-2020b/lib64/R/bin/R' --no-save --no-restore --no-echo 2>&1 < '/user/brussel/101/vsc10122/.local/easybuild-skylake/tmp/eb-S60DbH/RtmpjfMv1K/filec7565034ebf'
ERROR: lazy loading failed for package conumee

@boegel
Copy link
Member

boegel commented May 12, 2021

@boegelbot please test @ generoso
EB_ARGS="--skip"

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=12822 EB_ARGS="--skip" /apps/slurm/default/bin/sbatch --job-name test_PR_12822 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 17081

Test results coming soon (I hope)...

- notification for comment with ID 839491522 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso-c1-s-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/b3a8e3b954da14d79c4afdb1640a41aa for a full test report.

@boegel
Copy link
Member

boegel commented May 12, 2021

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3153.skitty.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/c8ac6c160f6b28151bac4136565f5455 for a full test report.

@boegel
Copy link
Member

boegel commented May 12, 2021

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node2601.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/8d07656c0972fcf8ffa5cfe4a00319d0 for a full test report.

@boegel
Copy link
Member

boegel commented May 12, 2021

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3506.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/d2fc9fa500e676de369c3447ce237688 for a full test report.

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented May 12, 2021

Going in, thanks @verdurin!

@boegel boegel merged commit b13bb61 into easybuilders:develop May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants