Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use correct Matlab Runtime Compiler (v8.4) for FreeSurfer v7.1.1 #13375

Merged

Conversation

btlindert
Copy link

(created using eb --new-pr)

Micket
Micket previously approved these changes Jul 10, 2021
Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, i guess this looks good to me.
Normally, modifying existing easyconfigs is something to strive to avoid. Perhaps this is a case where the runtime version should be added as a suffix to the easyconfig, to allow it to be distinguished. Though, reading the homepage, it seems like it should have been version 8.4 all along? I'm not entirely sure here.

@Micket Micket added the change label Jul 10, 2021
@Micket Micket added this to the 4.x milestone Jul 10, 2021
@Micket
Copy link
Contributor

Micket commented Jul 10, 2021

any opinion on this @sassy-crick ?

@sassy-crick
Copy link
Collaborator

Looking at the documentation it looks like the correct MCR is 8.4. I guess that would qualify as a patch-fix. There was no particular reason for me to pick the older version, I probably have just used the already existing EC file as a template and did not dig any deeper as it all was "working" for me.
Maybe we should add a comment that the MCR and FeeSurfer versions are linked?

@boegel boegel changed the title Update Matlab Runtime Compiler to 8.4 for FreeSurfer 7 use correct Matlab Runtime Compiler (v8.4) for FreeSurfer v7.1.1 Aug 23, 2022
@boegel boegel added bug fix and removed change labels Aug 23, 2022
@boegel
Copy link
Member

boegel commented Aug 23, 2022

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
node3100.skitty.os - Linux RHEL 8.4, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/edecbbe2784e78d86a060d4aa2855e46 for a full test report.

@boegel boegel modified the milestones: 4.x, next release (4.6.1?) Aug 23, 2022
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Aug 23, 2022

Going in, thanks @btlindert!

@boegel boegel merged commit 45bb940 into easybuilders:develop Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants