Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{lib,mpi}[GCC/11.2.0,GCCcore/11.2.0] OpenMPI v4.1.1, PMIx v4.1.0 #13668

Merged
merged 10 commits into from
Aug 19, 2021
Merged

{lib,mpi}[GCC/11.2.0,GCCcore/11.2.0] OpenMPI v4.1.1, PMIx v4.1.0 #13668

merged 10 commits into from
Aug 19, 2021

Conversation

Micket
Copy link
Contributor

@Micket Micket commented Aug 9, 2021

(created using eb --new-pr)

@Micket Micket added the update label Aug 9, 2021
@Micket
Copy link
Contributor Author

Micket commented Aug 9, 2021

This is broken, and I'm not sure how to fix the compilation errors.

@Micket Micket marked this pull request as draft August 9, 2021 17:41
@Micket
Copy link
Contributor Author

Micket commented Aug 9, 2021

Test report by @Micket
FAILED
Build succeeded for 1 out of 2 (2 easyconfigs in total)
alvis-c1 - Linux centos linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/9a33fcaf63d34342e4deb5d18283588a for a full test report.

@Micket @branfosj
Update easybuild/easyconfigs/p/PMIx/PMIx-4.1.0-GCCcore-11.2.0.eb
c27d2a3 
Co-authored-by: Simon Branford <4967+branfosj@users.noreply.github.com>
@Micket Micket mentioned this pull request Aug 10, 2021
Closed
@Micket
Copy link
Contributor Author

Micket commented Aug 10, 2021

Lets keep an eye on open-mpi/ompi#9212 and see if we should patch this (or maybe there will be a 4.1.2 version soon?)

@branfosj
Copy link
Member

Lets keep an eye on open-mpi/ompi#9212 and see if we should patch this (or maybe there will be a 4.1.2 version soon?)

I've tested and the build succeeds with that fix.

However, when I try to run I hit open-mpi/ompi#8596 and the workaround in open-mpi/ompi#8596 (comment) solves that issue.

@rhc54
Copy link

rhc54 commented Aug 10, 2021

FYI: I have posted a fix for open-mpi/ompi#8596 - see open-mpi/ompi#9213

SebastianAchilles
SebastianAchilles reviewed Aug 12, 2021
View reviewed changes
Copy link
Member

@SebastianAchilles SebastianAchilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Building worked for me when including open-mpi/ompi#9212 and open-mpi/ompi#9213

easybuild/easyconfigs/o/OpenMPI/OpenMPI-4.1.1-GCC-11.2.0.eb Show resolved Hide resolved
easybuild/easyconfigs/o/OpenMPI/OpenMPI-4.1.1-GCC-11.2.0.eb Show resolved Hide resolved
easybuild/easyconfigs/o/OpenMPI/OpenMPI-4.1.1-GCC-11.2.0.eb Show resolved Hide resolved
Micket and others added 3 commits August 12, 2021 16:33
@Micket
Update easybuild/easyconfigs/o/OpenMPI/OpenMPI-4.1.1-GCC-11.2.0.eb
f17c3d2 
Co-authored-by: SebastianAchilles <achilles@aices.rwth-aachen.de>
@Micket
Update easybuild/easyconfigs/o/OpenMPI/OpenMPI-4.1.1-GCC-11.2.0.eb
f1dc0db 
Co-authored-by: SebastianAchilles <achilles@aices.rwth-aachen.de>
@Micket
Update easybuild/easyconfigs/o/OpenMPI/OpenMPI-4.1.1-GCC-11.2.0.eb
3c4d396 
Co-authored-by: SebastianAchilles <achilles@aices.rwth-aachen.de>
@Micket
Update easybuild/easyconfigs/o/OpenMPI/OpenMPI-4.1.1-GCC-11.2.0.eb
7201b84 
Co-authored-by: SebastianAchilles <achilles@aices.rwth-aachen.de>
@SebastianAchilles SebastianAchilles added the 2021b issues & PRs related to 2021b label Aug 12, 2021
@SebastianAchilles
Copy link
Member

@boegelbot please test @ generoso
CORE_COUNT=16

@boegelbot
Copy link
Collaborator

@SebastianAchilles: Request for testing this PR well received on generoso

PR test command 'EB_PR=13668 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_13668 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 18103

Test results coming soon (I hope)...

- notification for comment with ID 897714783 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@SebastianAchilles
Copy link
Member

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
centos8-eb - Linux centos linux 8.3.2011, x86_64, Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz (skylake), Python 3.6.8
See https://gist.github.com/d3cc04cbb39db38cd021dd0f09e7ab50 for a full test report.

@SebastianAchilles
Copy link
Member

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
rocky8-eb - Linux rocky linux 8.4, x86_64, Intel(R) Core(TM) i7-6900K CPU @ 3.20GHz (broadwell), Python 3.6.8
See https://gist.github.com/6843279924234aa93d40948728473c3c for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
generoso-c1-s-4 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/2ea0f46ace78ba2c524efba37b12171e for a full test report.

@SebastianAchilles
Copy link
Member

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jrlogin11.jureca - Linux centos linux 8.3.2011, x86_64, AMD EPYC 7742 64-Core Processor, Python 3.6.8
See https://gist.github.com/989cacec6d14d0a7ffe13abea31ce510 for a full test report.

@SebastianAchilles
Copy link
Member

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsfl01.jusuf - Linux centos linux 7.9.2009, x86_64, AMD EPYC 7742 64-Core Processor, Python 3.6.8
See https://gist.github.com/0629695e3a48ac3aeeb3e3a7144f38b4 for a full test report.

@SebastianAchilles
Copy link
Member

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jwvis00.juwels - Linux centos linux 8.4.2105, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 3.6.8
See https://gist.github.com/f619ce91c45dd7153ef9a360d02a3bda for a full test report.

@branfosj branfosj mentioned this pull request Aug 12, 2021
Merged
1 task
@verdurin
Copy link
Member

@Micket do you consider this to be ready for review yet?

@Micket
Copy link
Contributor Author

Micket commented Aug 13, 2021

Well, did we wanna do something different with the patches or should i download and attach it here?

@Micket Micket marked this pull request as ready for review August 15, 2021 11:25
SebastianAchilles
SebastianAchilles previously approved these changes Aug 18, 2021
View reviewed changes
Copy link
Member

@SebastianAchilles SebastianAchilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Aug 18, 2021

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node2621.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/035e86629bd7ead08818f3b5ea907d16 for a full test report.

@branfosj
Copy link
Member

Test report by @branfosj
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
bear-pg0211u03a.bear.cluster - Linux RHEL 8.3, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/eda91954eee37177a73eccd3b906bfea for a full test report.

@branfosj
Copy link
Member

Test report by @branfosj
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
bear-pg0211u12a.bear.cluster - Linux Ubuntu 20.04, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.8.5
See https://gist.github.com/adeb61cef3fbb94d9272ff218e0b53df for a full test report.

@boegel
Copy link
Member

boegel commented Aug 18, 2021

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
select-pika-c6gd-2xlarge-0001 - Linux centos linux 8.3.2011, AArch64, ARM UNKNOWN (graviton2), Python 3.6.8
See https://gist.github.com/ab2f2f023b876d7354ced09e82b93904 for a full test report.

@boegel
Copy link
Member

boegel commented Aug 18, 2021

Test report by @boegel
SUCCESS
Build succeeded for 7 out of 7 (2 easyconfigs in total)
node3502.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/df1520c662ebe5a87fcb3c241c97839b for a full test report.

@branfosj
Copy link
Member

Test report by @branfosj
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
bear-pg0305u15a.bear.cluster - Linux RHEL 8.4, POWER, 8335-GTX (power9le), Python 3.6.8
See https://gist.github.com/78b9e6f5d8bda4e42f13f72407fdfcd8 for a full test report.

@boegel boegel mentioned this pull request Aug 18, 2021
Merged
boegel
boegel requested changes Aug 18, 2021
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Micket I would prefer adding a reference to the upstream PRs in the patches, since the commit ID in the patch is useless (due to rebasing, I guess)

done in Micket#7

@Micket
Merge pull request #7 from boegel/20210809194032_new_pr_OpenMPI411
3252852 
add reference to PRs in Open MPI GitHub repository in patches for OpenMPI 4.1.1
@boegel
Copy link
Member

boegel commented Aug 19, 2021

@boegelbot please test @ generoso
CORE_CNT=16

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=13668 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_13668 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 18158

Test results coming soon (I hope)...

- notification for comment with ID 901698690 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
generoso-x-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/a851ea01dbca373a7f66310a3fe14b0a for a full test report.

@boegel
Copy link
Member

boegel commented Aug 19, 2021

As discussed, let's merge this so we can test stuff on top of it.

If we want to make changes (like bump to OpenMPI 4.1.2, perhaps), there's still some time for that (next EasyBuild release is expected end of this month).

@boegel
Copy link
Member

boegel commented Aug 19, 2021

Going in, thanks @Micket!

@boegel boegel merged commit 23ed732 into easybuilders:develop Aug 19, 2021
@Micket Micket deleted the 20210809194032_new_pr_OpenMPI411 branch April 21, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@branfosj branfosj branfosj left review comments

@boegel boegel boegel approved these changes

@SebastianAchilles SebastianAchilles SebastianAchilles left review comments

Assignees
No one assigned
Labels
2021b issues & PRs related to 2021b update
Projects
None yet
Milestone
4.4.2
Development

Successfully merging this pull request may close these issues.
7 participants
@Micket @branfosj @rhc54 @SebastianAchilles @boegelbot @verdurin @boegel