Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{data}[GCCcore/10.3.0] Stata v17 #14144

Closed

Conversation

MaximeMoge
Copy link

(created using eb --new-pr)

@MaximeMoge
Copy link
Author

Test report by @MaximeMoge
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
int1.bullx - Linux RHEL 7.9, x86_64, Intel(R) Xeon(R) CPU E5-2690 0 @ 2.90GHz, Python 2.7.5
See https://gist.github.com/41df906cbe509135a417de9fa999f0f7 for a full test report.

@MaximeMoge
Copy link
Author

Test report by @MaximeMoge
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
int1.bullx - Linux RHEL 7.9, x86_64, Intel(R) Xeon(R) CPU E5-2690 0 @ 2.90GHz, Python 2.7.5
See https://gist.github.com/189496b3d804fc7922e2cb914950dba4 for a full test report.

@boegelbot
Copy link
Collaborator

@MaximeMoge: Tests failed in GitHub Actions, see https://github.com/easybuilders/easybuild-easyconfigs/actions/runs/1338306290
Output from first failing test suite run:

======================================================================
FAIL: test__parse_easyconfig_Stata-17-GCCcore-10.3.0.eb (test.easyconfigs.easyconfigs.EasyConfigTest)
Test for easyconfig Stata-17-GCCcore-10.3.0.eb
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/easyconfigs/easyconfigs.py", line 1355, in innertest
    template_easyconfig_test(self, spec_path)
  File "test/easyconfigs/easyconfigs.py", line 1193, in template_easyconfig_test
    "binutils or GCC is a build dep in %s: %s" % (spec, dep_names))
AssertionError: binutils or GCC is a build dep in /home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/easybuild/easyconfigs/s/Stata/Stata-17-GCCcore-10.3.0.eb: ['libpng', 'ncurses']

----------------------------------------------------------------------
Ran 13428 tests in 525.154s

FAILED (failures=1)
(skipped conflicts test)
(skipped dep graph test)
Merge base for develop and HEAD: d032b1b07f11ba1762cca2548a8c9f6793be00f5
Merge base for develop and HEAD: d032b1b07f11ba1762cca2548a8c9f6793be00f5

List of added easyconfig files in this PR:
	Stata-17-GCCcore-10.3.0.eb
ERROR: Not all tests were successful

bleep, bloop, I'm just a bot (boegelbot v20200716.01)
Please talk to my owner @boegel if you notice you me acting stupid),
or submit a pull request to https://github.com/boegel/boegelbot fix the problem.

@boegel boegel added the update label Oct 13, 2021
@boegel boegel added this to the 4.x milestone Oct 13, 2021
description = """Stata is a complete, integrated statistical software package that provides everything you need
for data analysis, data management, and graphics."""

toolchain = {'name': 'GCCcore', 'version': '10.3.0'}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MaximeMoge Why not use the SYSTEM toolchain here, since this is a binary installation?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because of the dependency on libpng/1.6.37-GCCcore-10.3.0

@MaximeMoge
Copy link
Author

Following @boegel 's comment I tried to use that easyconfig on another machine and it failed.
Turns out I was just lucky and I had all the required deps installed in the OS libraries on the machine I originally used. It looks like ncurses/6.2 and libpng/1.6.37 and not actually required, the stata binaries require ncurses.so.5 and libpng15.so.15

Let's put that PR on hold for now (or even reject it) while I figure this out.

Maxime Moge added 2 commits October 21, 2021 15:10
…(see easybuilders#3545) creating a soft link 'libtinfo.so -> libncurses.so' and extending it to create soft links 'libtinfo.so.5.9 -> libncurses.so.5.9' and 'libtinfo.so.5 -> libncurses.so.5' as well.
@MaximeMoge
Copy link
Author

I just updated the PR:

  • the Stata 17 binary depends on ncurses 5. libncurses.so.5 and libtinfo.so.5 are required.
  • In ncurses, tinfo is not installed in a separate lib libtinfo.so.5 by default. The configure option --with-termlib should be used to install tinfo in a separate lib. Another option is to use soft links as is done in the ncurses-6.X easyconfigs (see Statically link ncurses... #3545). I chose the latter, and updated the existing ncurses-5.9.eb easyconfig.

@boegelbot
Copy link
Collaborator

@MaximeMoge: Tests failed in GitHub Actions, see https://github.com/easybuilders/easybuild-easyconfigs/actions/runs/1368072255
Output from first failing test suite run:

======================================================================
(skipped conflicts test)
FAIL: test__parse_easyconfig_Stata-17-GCCcore-10.3.0.eb (test.easyconfigs.easyconfigs.EasyConfigTest)
(skipped dep graph test)
Test for easyconfig Stata-17-GCCcore-10.3.0.eb
Merge base for develop and HEAD: f74f370f068669140cf70c2575731bfe4cd85d1c
----------------------------------------------------------------------
Merge base for develop and HEAD: f74f370f068669140cf70c2575731bfe4cd85d1c
Traceback (most recent call last):

  File "test/easyconfigs/easyconfigs.py", line 1368, in innertest
List of changed easyconfig files in this PR:
    template_easyconfig_test(self, spec_path)
	ncurses-5.9.eb
  File "test/easyconfigs/easyconfigs.py", line 1206, in template_easyconfig_test

    "binutils or GCC is a build dep in %s: %s" % (spec, dep_names))
List of added easyconfig files in this PR:
AssertionError: binutils or GCC is a build dep in /home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/easybuild/easyconfigs/s/Stata/Stata-17-GCCcore-10.3.0.eb: ['libpng', 'ncurses']
	Stata-17-GCCcore-10.3.0.eb

======================================================================
FAIL: test_dep_versions_per_toolchain_generation (test.easyconfigs.easyconfigs.EasyConfigTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/easyconfigs/easyconfigs.py", line 783, in test_dep_versions_per_toolchain_generation
    self.assertFalse(multi_dep_vars, error_msg)
AssertionError: No multi-variant deps found for '^.*-(?P<tc_gen>GCCcore-([7-9]|[1-9][0-9])\.[0-9]).*\.eb$' easyconfigs:

found 2 variants of 'ncurses' dependency in easyconfigs using 'GCCcore-10.3' toolchain generation
* version: 5.9; versionsuffix:  as dep for set(['Stata-17-GCCcore-10.3.0.eb'])
* version: 6.2; versionsuffix:  as dep for set(['nvtop-1.2.1-GCCcore-10.3.0.eb', 'cairo-1.16.0-GCCcore-10.3.0.eb', 'util-linux-2.36-GCCcore-10.3.0.eb', 'protobuf-python-3.17.3-GCCcore-10.3.0.eb', 'longestrunsubsequence-1.0.1-GCCcore-10.3.0.eb', 'at-spi2-atk-2.38.0-GCCcore-10.3.0.eb', 'aria2-1.35.0-GCCcore-10.3.0.eb', 'bpytop-1.0.67-GCCcore-10.3.0.eb', 'GObject-Introspection-1.68.0-GCCcore-10.3.0.eb', 'BioPerl-1.7.8-GCCcore-10.3.0.eb', 'libglvnd-1.3.3-GCCcore-10.3.0.eb', 'intltool-0.51.0-GCCcore-10.3.0.eb', 'Python-2.7.18-GCCcore-10.3.0-bare.eb', 'ack-3.5.0-GCCcore-10.3.0.eb', 'Archive-Zip-1.68-GCCcore-10.3.0.eb', 'GLFW-3.3.4-GCCcore-10.3.0.eb', 'LAME-3.100-GCCcore-10.3.0.eb', 'Graphviz-2.47.2-GCCcore-10.3.0.eb', 'libepoxy-1.5.8-GCCcore-10.3.0.eb', 'JupyterLab-3.0.16-GCCcore-10.3.0.eb', 'APR-util-1.6.1-GCCcore-10.3.0.eb', 'GD-2.73-GCCcore-10.3.0.eb', 'git-2.32.0-GCCcore-10.3.0-nodocs.eb', 'glew-2.1.0-GCCcore-10.3.0.eb', 'tmux-3.2a-GCCcore-10.3.0.eb', 'Pillow-SIMD-8.2.0-GCCcore-10.3.0.eb', 'phototonic-2.1-GCCcore-10.3.0.eb', 'kim-api-2.2.1-GCCcore-10.3.0.eb', 'SDL2-2.0.14-GCCcore-10.3.0.eb', 'SCons-4.1.0.post1-GCCcore-10.3.0.eb', 'Python-3.9.5-GCCcore-10.3.0-bare.eb', 'Ghostscript-9.54.0-GCCcore-10.3.0.eb', 'GTK3-3.24.29-GCCcore-10.3.0.eb', 'FreeTDS-1.3.3-GCCcore-10.3.0.eb', 'PostgreSQL-13.3-GCCcore-10.3.0.eb', 'JupyterHub-1.4.1-GCCcore-10.3.0.eb', 'libdrm-2.4.106-GCCcore-10.3.0.eb', 'Qt5-5.15.2-GCCcore-10.3.0.eb', 'gnuplot-5.4.2-GCCcore-10.3.0.eb', 'cutadapt-3.4-GCCcore-10.3.0.eb', 'bashplotlib-0.6.5-GCCcore-10.3.0.eb', 'PyQt5-5.15.4-GCCcore-10.3.0.eb', 'pyproj-3.1.0-GCCcore-10.3.0.eb', 'Mesa-21.1.1-GCCcore-10.3.0.eb', 'glib-networking-2.68.1-GCCcore-10.3.0.eb', 'Tk-8.6.11-GCCcore-10.3.0.eb', 'DB_File-1.856-GCCcore-10.3.0.eb', 'Python-3.9.5-GCCcore-10.3.0.eb', 'Mercurial-5.8-GCCcore-10.3.0.eb', 'CubeGUI-4.6-GCCcore-10.3.0.eb', 'pkgconfig-1.5.4-GCCcore-10.3.0-python.eb', 'gexiv2-0.12.2-GCCcore-10.3.0.eb', 'LLVM-12.0.1-GCCcore-10.3.0.eb', 'freeglut-3.2.1-GCCcore-10.3.0.eb', 'Clang-12.0.1-GCCcore-10.3.0.eb', 'JSON-GLib-1.6.2-GCCcore-10.3.0.eb', 'canu-2.2-GCCcore-10.3.0.eb', 'Mako-1.1.4-GCCcore-10.3.0.eb', 'Vala-0.52.4-GCCcore-10.3.0.eb', 'GL2PS-1.4.2-GCCcore-10.3.0.eb', 'X11-20210518-GCCcore-10.3.0.eb', 'AOCC-3.1.0-GCCcore-10.3.0.eb', 'YACS-0.1.8-GCCcore-10.3.0.eb', 'dill-0.3.4-GCCcore-10.3.0.eb', 'babl-0.1.86-GCCcore-10.3.0.eb', 'at-spi2-core-2.40.2-GCCcore-10.3.0.eb', 'tqdm-4.61.1-GCCcore-10.3.0.eb', 'tqdm-4.61.2-GCCcore-10.3.0.eb', 'Perl-5.32.1-GCCcore-10.3.0.eb', 'parallel-20210622-GCCcore-10.3.0.eb', 'makeinfo-6.7-GCCcore-10.3.0.eb', 'gettext-0.21-GCCcore-10.3.0.eb', 'fontconfig-2.13.93-GCCcore-10.3.0.eb', 'CMake-3.20.1-GCCcore-10.3.0.eb', 'Nim-1.4.8-GCCcore-10.3.0.eb', 'Gdk-Pixbuf-2.42.6-GCCcore-10.3.0.eb', 'xprop-1.2.5-GCCcore-10.3.0.eb', 'PROJ-8.0.1-GCCcore-10.3.0.eb', 'GitPython-3.1.18-GCCcore-10.3.0.eb', 'hypothesis-6.13.1-GCCcore-10.3.0.eb', 'ZeroMQ-4.3.4-GCCcore-10.3.0.eb', 'GDB-10.2-GCCcore-10.3.0.eb', 'ImageMagick-7.0.11-14-GCCcore-10.3.0.eb', 'libgd-2.3.1-GCCcore-10.3.0.eb', 'LLVM-11.1.0-GCCcore-10.3.0.eb', 'libgeotiff-1.6.0-GCCcore-10.3.0.eb', 'GTS-0.7.6-GCCcore-10.3.0.eb', 'pytest-xdist-2.3.0-GCCcore-10.3.0.eb', 'SQLite-3.35.4-GCCcore-10.3.0.eb', 'GLib-2.68.2-GCCcore-10.3.0.eb', 'Pillow-8.2.0-GCCcore-10.3.0.eb', 'XlsxWriter-1.4.4-GCCcore-10.3.0.eb', 'gpustat-0.6.0-GCCcore-10.3.0.eb', 'plotly.py-5.1.0-GCCcore-10.3.0.eb', 'tcsh-6.22.04-GCCcore-10.3.0.eb', 'librsvg-2.51.2-GCCcore-10.3.0.eb', 'Mesa-demos-8.4.0-GCCcore-10.3.0.eb', 'XML-LibXML-2.0207-GCCcore-10.3.0.eb', 'HarfBuzz-2.8.1-GCCcore-10.3.0.eb', 'python-isal-0.11.0-GCCcore-10.3.0.eb', 'flatbuffers-python-2.0-GCCcore-10.3.0.eb', 'GEGL-0.4.30-GCCcore-10.3.0.eb', 'Subversion-1.14.1-GCCcore-10.3.0.eb', 'ATK-2.36.0-GCCcore-10.3.0.eb', 'GTK+-2.24.33-GCCcore-10.3.0.eb', 'XML-Parser-2.46-GCCcore-10.3.0-Perl-5.32.1.eb', 'GTK2-2.24.33-GCCcore-10.3.0.eb', 'cppy-1.1.0-GCCcore-10.3.0.eb', 'libreadline-8.1-GCCcore-10.3.0.eb', 'pybind11-2.6.2-GCCcore-10.3.0.eb', 'archspec-0.1.2-GCCcore-10.3.0.eb', 'Flask-1.1.4-GCCcore-10.3.0.eb', 'typing-extensions-3.10.0.0-GCCcore-10.3.0.eb', 'lxml-4.6.3-GCCcore-10.3.0.eb', 'expecttest-0.1.3-GCCcore-10.3.0.eb', 'Meson-0.58.0-GCCcore-10.3.0.eb', 'Xvfb-1.20.11-GCCcore-10.3.0.eb', 'Gurobi-9.1.2-GCCcore-10.3.0.eb', 'Serf-1.3.9-GCCcore-10.3.0.eb', 'AOCC-3.0.0-GCCcore-10.3.0.eb', 'PyCairo-1.20.1-GCCcore-10.3.0.eb', 'radeontop-1.3-GCCcore-10.3.0.eb', 'libmypaint-1.6.1-GCCcore-10.3.0.eb', 'PyYAML-5.4.1-GCCcore-10.3.0.eb', 'libGLU-9.0.1-GCCcore-10.3.0.eb', 'Tkinter-3.9.5-GCCcore-10.3.0.eb', 'IPython-7.25.0-GCCcore-10.3.0.eb', 'LDC-1.26.0-GCCcore-10.3.0.eb', 'FLTK-1.3.6-GCCcore-10.3.0.eb', 'FFmpeg-4.3.2-GCCcore-10.3.0.eb', 'Lua-5.4.3-GCCcore-10.3.0.eb', 'libdap-3.20.7-GCCcore-10.3.0.eb', 'Pango-1.48.5-GCCcore-10.3.0.eb', 'openpyxl-3.0.7-GCCcore-10.3.0.eb', 'scikit-build-0.11.1-GCCcore-10.3.0.eb'])


----------------------------------------------------------------------
Ran 13497 tests in 539.386s

FAILED (failures=2)
ERROR: Not all tests were successful

bleep, bloop, I'm just a bot (boegelbot v20200716.01)
Please talk to my owner @boegel if you notice you me acting stupid),
or submit a pull request to https://github.com/boegel/boegelbot fix the problem.

@lexming
Copy link
Contributor

lexming commented Jul 22, 2022

@MaximeMoge thanks for your contribution, I continued your work here and fixed the issues with this PR:

  • as requested by @boegel, Stata should be installed in the SYSTEM toolchain as this is just a binary package
  • the dependency on libpng can be solved by adding a new easyconfig for it in SYSTEM as well
  • as you found out, Stata depends on an older libpng15.so.15 which is not provided by libpng v1.6, so making a new easyconfig is needed in any case
  • moving to SYSTEM also solves the issue with ncurses v5.9, which is not default in GCCcore/10.3.0

I opened a new PR keeping your commits and adding my changes. So I'll close this one as superseded by #15899.

@lexming lexming closed this Jul 22, 2022
@lexming lexming modified the milestones: 4.x, next release (4.6.1?) Jul 22, 2022
@boegel boegel modified the milestones: next release (4.6.1?), 4.x Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants