Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add compiler/parallel/tcltk R libraries included in base installation to extensions in R 4.x easyconfigs using foss toolchain #14189

Merged
merged 1 commit into from
Oct 22, 2021

Conversation

boegel
Copy link
Member

@boegel boegel commented Oct 21, 2021

(created using eb --new-pr)

Including these additional libraries in exts_list doesn't actually affect the installation at all, since they're always installed, even when not listed explicitly as extension.

The main motivation for doing this is to ensure that base R libraries that are listed as a required dependency for R libraries from CRAN are included in exts_list, which is required to be able to install the extensions in parallel (cfr. easybuilders/easybuild-framework#3667 and easybuilders/easybuild-easyblocks#2408).

(I'll open separate PRs for R easyconfigs using a fosscuda toolchain, and for older versions, to facilitate submitting test reports)

… to extensions in R 4.x easyconfigs using foss toolchain
@boegel boegel added this to the 4.5.0 (next release) milestone Oct 21, 2021
@boegel
Copy link
Member Author

boegel commented Oct 21, 2021

@boegelbot please test @ generoso
EB_ARGS="--skip"

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=14189 EB_ARGS="--skip" /opt/software/slurm/bin/sbatch --job-name test_PR_14189 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7136

Test results coming soon (I hope)...

- notification for comment with ID 948955388 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
cnx3 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/64be6812678c21354f973fd9d3095058 for a full test report.

Copy link
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Contributor

Going in, thanks @boegel!

@akesandgren akesandgren merged commit 92fea27 into easybuilders:develop Oct 22, 2021
@boegel boegel deleted the 20211021214507_new_pr_R400 branch October 22, 2021 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants