Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{bio}[gompi/2021b] UShER v0.5.0 w/ Python 3.9.6 #14305

Conversation

sassy-crick
Copy link
Collaborator

(created using eb --new-pr)

@sassy-crick
Copy link
Collaborator Author

sassy-crick commented Nov 8, 2021

Requires:

@easybuilders easybuilders deleted a comment from boegelbot Dec 1, 2021
Sassy and others added 2 commits December 1, 2021 12:00
Updated easyconfigs.py to add exemption for TBB version checking for UShER
@migueldiascosta
Copy link
Member

@sassy-crick it sees you committed a new copy of easyconfigs.py at the top of the repo, it should be a change to test/easyconfigs/easyconfigs.py (otherwise, the changes look good to me)

easyconfigs.py added to test directory
File moved to correct folder
@sassy-crick
Copy link
Collaborator Author

@migueldiascosta Thanks for your help. It does make more sense indeed.
I am not sure if I made a mess of it as these two lines were also removed, but not by me:

  # Shasta requires spoa 3.x
            'spoa': [(r'3\.4\.0', [r'Shasta-0\.8\.0-'])],

From the commit message I saw I think @boegel done something here. I don't want accidentally introduce a bug!

@migueldiascosta
Copy link
Member

@sassy-crick I suppose you started from a version of easyconfigs.py from before @boegel added those lines, so you are indeed inadvertently removing them here...

@sassy-crick
Copy link
Collaborator Author

@migueldiascosta yes, that is what happened. I thought it is better to ask what to do instead of making more of a mess.
Thanks for helping here.
However, I am lost why the checks are not working now. It looks like the lines @boegel added are the problem here but then I might be wrong.
:-(

@migueldiascosta
Copy link
Member

@sassy-crick sassy-crick#7 should fix it

@easybuilders easybuilders deleted a comment from boegelbot Dec 3, 2021
@easybuilders easybuilders deleted a comment from boegelbot Dec 3, 2021
@migueldiascosta
Copy link
Member

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@migueldiascosta: Request for testing this PR well received on login1

PR test command 'EB_PR=14305 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14305 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7426

Test results coming soon (I hope)...

- notification for comment with ID 985163026 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/bd18357984fcbcd2e44c78f6ca623c3e for a full test report.

Copy link
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta
Copy link
Member

Going in, thanks @sassy-crick!

@migueldiascosta migueldiascosta merged commit 14a0d77 into easybuilders:develop Dec 3, 2021
@sassy-crick sassy-crick deleted the 20211108230612_new_pr_UShER050 branch December 4, 2021 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants