-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{bio}[gompi/2021b] UShER v0.5.0 w/ Python 3.9.6 #14305
{bio}[gompi/2021b] UShER v0.5.0 w/ Python 3.9.6 #14305
Conversation
….0_external-tbb.patch
…asyconfigs into 20211108230612_new_pr_UShER050
…ted to reflect this
Updated easyconfigs.py to add exemption for TBB version checking for UShER
@sassy-crick it sees you committed a new copy of |
easyconfigs.py added to test directory
File moved to correct folder
@migueldiascosta Thanks for your help. It does make more sense indeed.
From the commit message I saw I think @boegel done something here. I don't want accidentally introduce a bug! |
@sassy-crick I suppose you started from a version of easyconfigs.py from before @boegel added those lines, so you are indeed inadvertently removing them here... |
…asyconfigs into 20211108230612_new_pr_UShER050
@migueldiascosta yes, that is what happened. I thought it is better to ask what to do instead of making more of a mess. |
@sassy-crick sassy-crick#7 should fix it |
add back deleted lines
@boegelbot please test @ generoso |
@migueldiascosta: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 985163026 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Going in, thanks @sassy-crick! |
(created using
eb --new-pr
)