Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlexiBLAS: Workaround miscompilation on PPC #15867

Closed
wants to merge 1 commit into from
Closed

FlexiBLAS: Workaround miscompilation on PPC #15867

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions easybuild/easyconfigs/f/FlexiBLAS/FlexiBLAS-3.0.4-GCC-10.3.0.eb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,13 @@ toolchain = {'name': 'GCC', 'version': '10.3.0'}
local_extra_flags = "-fstack-protector-strong -fstack-clash-protection"
toolchainopts = {'pic': True, 'extra_cflags': local_extra_flags, 'extra_fflags': local_extra_flags}

if ARCH == 'ppc64le':
Copy link
Member

@ocaisa ocaisa Jul 20, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to stall this, but in general I think it is better if we avoid logic in easyconfigs if possible (since they are not supposed to contain any). Instead you could create a local_configopts dict and just add local_configopts[ARCH] to the component.
I say this because this easyconfig will now fall over with some of the try-* options. (Well, not fall over but it will evaluate that logic and it will be lost)

Copy link
Member

@ocaisa ocaisa Jul 20, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW ARCH is not defined is it? Shouldn't it be %(arch)s?
Show's how much I know! List of current known archs is at https://github.com/easybuilders/easybuild-framework/blob/develop/easybuild/tools/systemtools.py#L93

# Workaround optimizer bug in GCC
# See https://github.com/easybuilders/easybuild-easyconfigs/issues/12968
local_configopts = '-DCMAKE_C_FLAGS_RELEASE="-O0"'
else:
local_configopts = ''

builddependencies = [
('CMake', '3.20.1'),
('Python', '3.9.5'), # required for running the tests
Expand All @@ -35,6 +42,7 @@ components = [
'sources': [SOURCELOWER_TAR_GZ],
'checksums': ['50a88f2e88994dda91b2a2621850afd9654b3b84820e737e335687a46751be5c'],
'backends': local_backends,
'configopts': local_configopts,
}),
('LAPACK', '3.10.0', {
'easyblock': 'CMakeMake',
Expand Down