-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add libffi and elfutils as dependency for Clang v11.0.1 + v12.0.1 #15935
add libffi and elfutils as dependency for Clang v11.0.1 + v12.0.1 #15935
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm (as discussed in slack, this was pretty clear cut; libomptarget.* dynamically links to both libffi and libelf)
Test report by @Micket |
@boegelbot please test @ generoso |
@Micket: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1201207610 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
Going in, thanks @bowentan! |
I've made this fix consistent in recent |
@boegel Then I am interested in the test result of #16225 for Clang11.0.1 as I reported a possible issue with the easyblock: fix sanity checks for Clang 11 when built with NVPTX support easyblocks/#2782 |
@zdemat I'll keep an eye out for that, thanks for the PR! |
(created using
eb --new-pr
)Add libffi and elfutils as dependencies