Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{bio}[foss/2021a] OpenFold v1.0.0, colossalai v0.1.8, einops v0.4.1, OpenMM 7.5.1 (incl. AlphaFold patch) w/ Python 3.9.5 + CUDA 11.3.1 #15971
{bio}[foss/2021a] OpenFold v1.0.0, colossalai v0.1.8, einops v0.4.1, OpenMM 7.5.1 (incl. AlphaFold patch) w/ Python 3.9.5 + CUDA 11.3.1 #15971
Changes from 1 commit
4fe2a10
9cd691b
e24daad
99d129d
76c6ea9
dbf7314
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does it need that specific version? We have
Ninja-1.10.1-GCCcore-10.2.0.eb
which is this thing (to be used as a builddep only i assume?)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but that provides only the
ninja
binary, anddeepspeed
requires theninja
python package...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we could enhance the (recent)
Ninja
easyconfigs to also install the Python bindings (I'm looking into that, PR coming soon...)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see #16025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the
ninja
Python package, provided by https://github.com/scikit-build/ninja-python-distributions, is actually a shim package, a very light-weight wrapper around theninja
binary so you can declare a dependency on it insetup.py
& co...With that in mind, I think it should be OK to just strip out the requirement for
ninja
as long as we provide the traditionalNinja
as a (build) depemdency.I'll look into this (and then close #16025 since that PR doesn't make much sense then)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, just stripping out the requirement for the
ninja
Python package won't be a good idea, sincedeepspeed
really does require it (if only to check whetherNinja
is available), see https://github.com/microsoft/DeepSpeed/blob/316c4a43e0802a979951ee17f735daf77ea9780f/deepspeed/env_report.py#L54-L59So unless we can somehow make the
ninja
Python package point to an existingNinja
installation rather than having it install it's ownninja
binary, this may be a necessary evil that's hard to avoid... :-/There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I closed #16025, since that's clearly not the correct way forward.
Since the
ninja
Python package is also a runtime dependency fordeepspeed
, I don't see a better way out than the current approach being used here: installninja
as an extension inOpenFold
(as opposed to trying to use the classicNinja
installation as a dependency somehow).