Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing BCFtools dependency for recent medaka versions #16107

Merged
merged 1 commit into from
Aug 24, 2022
Merged

add missing BCFtools dependency for recent medaka versions #16107

merged 1 commit into from
Aug 24, 2022

Conversation

boegel
Copy link
Member

@boegel boegel commented Aug 23, 2022

(created using eb --new-pr)

@boegel
add missing BCFtools dependency for recent medaka versions (+ run med…
9661163 
…aka_version_report to catch missing required dependencies)
@boegel boegel added the bug fix label Aug 23, 2022
@boegel boegel added this to the next release (4.6.1?) milestone Aug 23, 2022
@boegel boegel changed the title add missing BCFtools dependency for recent medaka versions (+ run medaka_version_report to catch missing required dependencies) add missing BCFtools dependency for recent medaka versions Aug 23, 2022
@boegel
Copy link
Member Author

boegel commented Aug 23, 2022

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=16107 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_16107 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9049

Test results coming soon (I hope)...

- notification for comment with ID 1224415795 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Member Author

boegel commented Aug 23, 2022

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
node3505.doduo.os - Linux RHEL 8.4, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/67edb600174ef56c1678783daebc37cc for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/edb3e2bc691b5866dc9b20b6f931fdfd for a full test report.

@boegel boegel mentioned this pull request Aug 23, 2022
Merged
@verdurin
Copy link
Member

Test report by @verdurin
SUCCESS
Build succeeded for 42 out of 42 (3 easyconfigs in total)
easybuild-c7.novalocal - Linux CentOS Linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/45c270d1ab577a3872d7d226a5b7b84d for a full test report.

verdurin
verdurin approved these changes Aug 24, 2022
View reviewed changes
Copy link
Member

@verdurin verdurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@verdurin
Copy link
Member

Going in, thanks @boegel!

@verdurin verdurin merged commit fd4b64d into easybuilders:develop Aug 24, 2022
@boegel boegel deleted the 20220823192759_new_pr_medaka143 branch August 24, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@verdurin verdurin verdurin approved these changes

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
4.6.1
Development

Successfully merging this pull request may close these issues.
3 participants
@boegel @boegelbot @verdurin