Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make check for toolchain value in dependency spec in easyconfigs test suite aware that dumped easyconfig uses SYSTEM constant #16126

Merged
merged 2 commits into from
Aug 26, 2022

Conversation

boegel
Copy link
Member

@boegel boegel commented Aug 25, 2022

… suite aware that dumped easyconfig uses SYSTEM constant
@boegel
Copy link
Member Author

boegel commented Aug 25, 2022

The tests for this PR will fail until easybuilders/easybuild-framework#4069 is merged, but this PR will need to get merged ASAP after the merging of easybuilders/easybuild-framework#4069 to avoid broken tests in PRs being opened...

@boegelbot

This comment was marked as outdated.

Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket enabled auto-merge August 26, 2022 10:36
Micket
Micket previously requested changes Aug 26, 2022
test/easyconfigs/easyconfigs.py Outdated Show resolved Hide resolved
use `cond is True` instead of `cond == True`

Co-authored-by: Mikael Öhman <micketeer@gmail.com>
@Micket Micket merged commit 4ac0386 into easybuilders:develop Aug 26, 2022
@boegel boegel deleted the system_constant_tc_dep branch August 26, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants