Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove modextrapaths to add top-level install directory to $PATH for recent InterProScan easyconfigs (now done by default by Binary easyblock) #16167

Merged
merged 3 commits into from
Sep 6, 2022

Conversation

Ghepardo
Copy link
Contributor

(created using eb --new-pr)

…d that path '' was already added. This parameter is no longer necessary, now that we are using the Binary easyblock, which adds the root of the installation path to PATH by default.
@boegel boegel changed the title Removed modextrapaths setting, which resulted in warnings during build that path '' was already added. This parameter is no longer necessary, now that we are using the Binary easyblock, which adds the root of the installation path to PATH by default. remove modextrapaths to add top-level install directory to $PATH for InterProScan v5.55-88.0 (now done by default by Binary easyblock) Aug 31, 2022
@boegel boegel added the bug fix label Aug 31, 2022
@boegel boegel added this to the next release (4.6.1?) milestone Aug 31, 2022
@boegel
Copy link
Member

boegel commented Aug 31, 2022

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=16167 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_16167 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9094

Test results coming soon (I hope)...

- notification for comment with ID 1233011822 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns3 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/4cfceb3ab1d590ccaa4d9402587978cb for a full test report.

…syconfig for InterProScan v5.52-86.0 (+ remove superfluous comment)
@boegel boegel changed the title remove modextrapaths to add top-level install directory to $PATH for InterProScan v5.55-88.0 (now done by default by Binary easyblock) remove modextrapaths to add top-level install directory to $PATH for recent InterProScan easyconfigs (now done by default by Binary easyblock) Aug 31, 2022
@boegel
Copy link
Member

boegel commented Aug 31, 2022

Test report by @boegel
FAILED
Build succeeded for 1 out of 2 (2 easyconfigs in total)
node3100.skitty.os - Linux RHEL 8.4, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/0e32e7221c7002e617e85dc052d7b027 for a full test report.

@Ghepardo
Copy link
Contributor Author

Ghepardo commented Sep 1, 2022

That test failure looks as though it was for a different InterProScan version, for some reason (5.52-86 instead of 5.55.88). Is any action required of me here?

@boegel
Copy link
Member

boegel commented Sep 1, 2022

@Ghepardo I was trying to make the fix a bit more consistent, by also updating the older InterProScan in the same way.

I'll look into the failing test, no action needed from you

@boegel
Copy link
Member

boegel commented Sep 6, 2022

Ah, the problem is that InterProScan-5.52-86.0-GCCcore-10.3.0.eb uses the Tarball easyblock, where the modextrapaths is actually still needed (it's only done automatically when the Binary easyblock is used, which is only the case for InterProScan-5.55-88.0-foss-2021a.eb).

…InterProScan 5.52-86.0 easyconfig, still required since Tarball easyblock is used
@boegel
Copy link
Member

boegel commented Sep 6, 2022

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=16167 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_16167 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 1622

Test results coming soon (I hope)...

- notification for comment with ID 1238150801 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (2 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/7bf4889161aaec3a586ab2edc9d1ab96 for a full test report.

@boegel
Copy link
Member

boegel commented Sep 6, 2022

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node3151.skitty.os - Linux RHEL 8.4, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/9fddfc8a6ca30d9d04df0287e9471eb3 for a full test report.

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Sep 6, 2022

Going in, thanks @Ghepardo!

@boegel boegel merged commit d98ab3f into easybuilders:develop Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants