-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove modextrapaths to add top-level install directory to $PATH for recent InterProScan easyconfigs (now done by default by Binary easyblock) #16167
remove modextrapaths to add top-level install directory to $PATH for recent InterProScan easyconfigs (now done by default by Binary easyblock) #16167
Conversation
…d that path '' was already added. This parameter is no longer necessary, now that we are using the Binary easyblock, which adds the root of the installation path to PATH by default.
@boegelbot please test @ generoso |
@boegel: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1233011822 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
…syconfig for InterProScan v5.52-86.0 (+ remove superfluous comment)
Test report by @boegel |
That test failure looks as though it was for a different InterProScan version, for some reason (5.52-86 instead of 5.55.88). Is any action required of me here? |
@Ghepardo I was trying to make the fix a bit more consistent, by also updating the older InterProScan in the same way. I'll look into the failing test, no action needed from you |
Ah, the problem is that |
…InterProScan 5.52-86.0 easyconfig, still required since Tarball easyblock is used
@boegelbot please test @ jsc-zen2 |
@boegel: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1238150801 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
Test report by @boegel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Going in, thanks @Ghepardo! |
(created using
eb --new-pr
)