Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add make 4.3 as build dependency for recent OpenBLAS versions #17924

Merged

Conversation

TopRichard
Copy link
Contributor

@TopRichard TopRichard commented May 19, 2023

(created using eb --new-pr)
Using this easyconfig of OpenBLAS-0.3.15-GCC-10.3.0 with make 4.3 for EESSI/2023.04 stack

edit (by @boegel): required because of problems if make 4.4 (provided by the OS) is used, cfr. OpenMathLib/OpenBLAS#3899 (so required for OpenBLAS < 0.3.22)

@boegel boegel added the bug fix label May 19, 2023
@boegel boegel added this to the next release (4.7.2) milestone May 19, 2023
@verdurin
Copy link
Member

@boegelbot please test @ generoso

@verdurin
Copy link
Member

Test report by @verdurin
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
easybuild-c7.novalocal - Linux CentOS Linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/verdurin/80a32de553aa82761e5ce0c3cdc8aec1 for a full test report.

@boegelbot
Copy link
Collaborator

@verdurin: Request for testing this PR well received on login1

PR test command 'EB_PR=17924 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_17924 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10845

Test results coming soon (I hope)...

- notification for comment with ID 1557213994 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/656396528cf32898d6cb8ab482c55890 for a full test report.

@verdurin
Copy link
Member

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Collaborator

@verdurin: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=17924 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_17924 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 2646

Test results coming soon (I hope)...

- notification for comment with ID 1557235670 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@verdurin
Copy link
Member

This could probably benefit from wider testing - @branfosj ? @lexming ?

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/5697dd0f5f4249fd6ae7c648d8f9e8f9 for a full test report.

@boegel boegel changed the title Adding make 4.3 as build-dependency for OpenBLAS-0.3.15-GCC-10.3.0 add make 4.3 as build dependency for recent OpenBLAS versions May 22, 2023
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented May 22, 2023

Test report by @boegel
SUCCESS
Build succeeded for 11 out of 11 (11 easyconfigs in total)
node3133.skitty.os - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/boegel/aca9049b7bb355e5eb25fff269db37bf for a full test report.

@boegel
Copy link
Member

boegel commented May 23, 2023

Going in, thanks @TopRichard!

@boegel boegel merged commit 99eb909 into easybuilders:develop May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants