Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix installation of Python bindings for recent Arrow easyconfigs by adding --no-build-isolation to pip install command #18348

Merged
merged 2 commits into from
Aug 1, 2023
Merged

fix installation of Python bindings for recent Arrow easyconfigs by adding --no-build-isolation to pip install command #18348

merged 2 commits into from
Aug 1, 2023

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Jul 19, 2023 •
edited by boegel
Loading

(created using eb --new-pr)

fixes #18327

This was referenced Jul 19, 2023
Closed
Closed
@branfosj branfosj added this to the next release (4.8.1?) milestone Jul 19, 2023
@branfosj
Copy link
Member Author

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@branfosj: Request for testing this PR well received on login1

PR test command 'EB_PR=18348 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_18348 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11270

Test results coming soon (I hope)...

- notification for comment with ID 1642196333 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@branfosj
Copy link
Member Author

Test report by @branfosj
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
bear-pg0104u07b - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/1a8ae3c769a0235caa1a18e8fef6d351 for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/623e4737619816880a3799c8904f8282 for a full test report.

@branfosj branfosj changed the title add --no-build-isolation to Arrow easyconfigs add --no-build-isolation to Arrow easyconfigs Jul 19, 2023
@branfosj
Copy link
Member Author

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Collaborator

@branfosj: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=18348 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_18348 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3008

Test results coming soon (I hope)...

- notification for comment with ID 1646570910 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 9 out of 9 (5 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/618b9a972aebd0b9ba2dd93a8a398ebe for a full test report.

@boegel
Copy link
Member

boegel commented Aug 1, 2023

Test report by @boegel
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
node3142.skitty.os - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/boegel/165c70be17db05a8fa375427010fdfc4 for a full test report.

@boegel boegel changed the title add --no-build-isolation to Arrow easyconfigs fix installation of Python bindings for recent Arrow easyconfigs by add --no-build-isolation to pip install command Aug 1, 2023
boegel
boegel approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Aug 1, 2023

Going in, thanks @branfosj!

@boegel boegel merged commit c60d52f into easybuilders:develop Aug 1, 2023
@branfosj branfosj deleted the 20230719152543_new_pr_Arrow1100 branch August 1, 2023 08:53
@boegel boegel changed the title fix installation of Python bindings for recent Arrow easyconfigs by add --no-build-isolation to pip install command fix installation of Python bindings for recent Arrow easyconfigs by adding --no-build-isolation to pip install command Aug 1, 2023
@boegel
Copy link
Member

boegel commented Aug 1, 2023

@branfosj You missed a spot, see #18432

This was referenced Aug 1, 2023
Merged
Merged
Merged
@boegel boegel mentioned this pull request Sep 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfgrimm jfgrimm jfgrimm left review comments

@verdurin verdurin verdurin left review comments

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
4.8.1
Development

Successfully merging this pull request may close these issues.

Failure to build pyarrow wheel due to Cython incompatibility during Arrow install
5 participants
@branfosj @boegelbot @boegel @verdurin @jfgrimm