-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{toolchain} intel/2023.07 #18439
{toolchain} intel/2023.07 #18439
Conversation
…-2023.07.eb, imkl-2023.2.0.eb, imkl-FFTW-2023.2.0-iimpi-2023.07.eb, impi-2021.10.0-intel-compilers-2023.2.1.eb, intel-compilers-2023.2.1.eb
easybuild/easyconfigs/i/intel-compilers/intel-compilers-2023.2.1.eb
Outdated
Show resolved
Hide resolved
Test report by @SebastianAchilles |
Test report by @SebastianAchilles |
Test report by @SebastianAchilles |
@boegelbot please test @ generoso |
@SebastianAchilles: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1660810346 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
@boegelbot please test @ jsc-zen2 |
@SebastianAchilles: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1660833787 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
Test report by @casparvl |
Hmm, seeing lots of |
The failure seems to be related to our site using EB's RPATH support. The reason this leads to errors is because of a combination of The solution would be to make sure that either warnings are not enabled for unused arguments or that they are not turned into errors. I'll have a look to see if any prior versions of FFTW also did this and what we did to avoid this. I remember having seen this error pattern before, but can't remember with which software that was... |
Found it: used to have this issue with Clang, see this code section in the clang EasyBlock. Maybe we can do something similar for FFTW? I do wonder why we haven't see this with older versions, but maybe the |
I tried a somewhat naive addition of
to the EasyBlock. That doesn't help. Looking more closely, I see that for a lot of build targets, we don't actually see the problem:
even though
So my addition of The problematic section is this:
So, here it is Question now is: what do I need to change to modify the CFLAGS that are used at this particular stage in the build. Which file is calling for that environment change? Well, that would be here. I'll try to modify |
Yep, putting
in |
Test report by @casparvl |
So, this PR looks good to me in the sense that it is building now. I guess the only open question is this from @boegel . I'm not fully up to date on what we now do by default in EB: did we already switch to the dcpp compilers by default? I.e. is that why @boegel is surprised here about the use of |
Discussed with @boegel : we should open a separate issue for the icc stuff. He had a short look, it seems the |
Test report by @casparvl |
@SebastianAchilles The plan here is still to change to |
Yes, that is the plan. Since a UCX for |
Test report by @SebastianAchilles |
Test report by @SebastianAchilles |
Test report by @SebastianAchilles |
@boegelbot please test @ jsc-zen2 |
@SebastianAchilles: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1737634060 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
@boegelbot please test @ generoso |
@SebastianAchilles: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1737821776 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
easybuild/easyconfigs/i/impi/impi-2021.10.0-intel-compilers-2023.2.1.eb
Outdated
Show resolved
Hide resolved
Co-authored-by: Kenneth Hoste <kenneth.hoste@ugent.be>
@boegelbot please test @ jsc-zen2 |
@SebastianAchilles: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1739464249 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
…asyconfigs into 20230801184345_new_pr_intel202307
@boegelbot please test @ generoso |
@SebastianAchilles: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1739622953 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Test report by @boegel |
Going in, thanks @SebastianAchilles! |
(created using
eb --new-pr
)