Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't disable building of third and fourth derivates in libxc 6.1.0 #18467

Merged
merged 3 commits into from
Oct 23, 2023

Conversation

boegel
Copy link
Member

@boegel boegel commented Aug 5, 2023

(created using eb --new-pr)

see also pyscf/pyscf#1103

@boegel boegel added this to the next release (4.8.1?) milestone Aug 5, 2023
@boegel
Copy link
Member Author

boegel commented Aug 6, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=18467 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_18467 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11392

Test results coming soon (I hope)...

- notification for comment with ID 1666861096 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Member Author

boegel commented Aug 6, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=18467 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_18467 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3094

Test results coming soon (I hope)...

- notification for comment with ID 1666930601 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns8 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/ba5dcc82600127e573f1ff8ec9426db5 for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/0f2bb7118cdb230cec143ef626fc0235 for a full test report.

Copy link
Member

@branfosj branfosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should cleanup the unused option while we are making a change.

@SebastianAchilles
Copy link
Member

Since building the third and fourth derivatives takes some time: Is parallel = 1 still needed?

After removing parallel = 1 from the easyconfig I got these build times for libxc-6.1.0-GCC-12.2.0.eb:

parallel = 1 parallel = 64
4h15m22 25m33

@branfosj
Copy link
Member

branfosj commented Aug 7, 2023

Since building the third and fourth derivatives takes some time: Is parallel = 1 still needed?

That has been there since it was a ConfigureMake in version 2.0.1 and we are now CMakeMake and version 6.1.0.

boegel and others added 2 commits August 7, 2023 22:44
@boegel
Copy link
Member Author

boegel commented Aug 7, 2023

@boegelbot please test @ generoso
CORE_CNT=16

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=18467 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_18467 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11398

Test results coming soon (I hope)...

- notification for comment with ID 1668556215 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Member Author

boegel commented Aug 7, 2023

@boegelbot please test @ jsc-zen2
CORE_CNT=16

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=18467 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_18467 --ntasks="16" ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3099

Test results coming soon (I hope)...

- notification for comment with ID 1668565829 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/cab5277afb2d13a3d5d0d0087f18a970 for a full test report.

@boegel
Copy link
Member Author

boegel commented Aug 7, 2023

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node3116.skitty.os - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/boegel/d763de6b9c11fc2db54acf6674d60f63 for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cnx1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/4e9802766418184d0b687175a460e056 for a full test report.

@SebastianAchilles
Copy link
Member

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
zen2-ubuntu-2304 - Linux Ubuntu 23.04 (Lunar Lobster), x86_64, AMD EPYC 7452 32-Core Processor (zen2), Python 3.11.2
See https://gist.github.com/SebastianAchilles/0f9040bec8143277058c923092bf2dad for a full test report.

@boegel
Copy link
Member Author

boegel commented Aug 8, 2023

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node4111.gallade.os - Linux RHEL 8.6, x86_64, AMD EPYC 7773X 64-Core Processor (zen3), Python 3.6.8
See https://gist.github.com/boegel/11661d9bd403ce7c19f4d8ae8e3c0b65 for a full test report.

@casparvl
Copy link
Contributor

casparvl commented Aug 9, 2023

Test report by @casparvl
FAILED
Build succeeded for 1 out of 2 (2 easyconfigs in total)
tcn1.local.snellius.surf.nl - Linux RHEL 8.6, x86_64, AMD EPYC 7H12 64-Core Processor, Python 3.6.8
See https://gist.github.com/casparvl/7c5cb8f0721b8456da487ff709d07028 for a full test report.

@casparvl
Copy link
Contributor

casparvl commented Aug 9, 2023

Strange... it's complaining about not being able to open input files, while the build with intel-compilers completes fine. That seems impossible to me. I'll rerun, just to see if it was somehow a hickup.

@casparvl
Copy link
Contributor

casparvl commented Aug 9, 2023

Test report by @casparvl
FAILED
Build succeeded for 1 out of 2 (2 easyconfigs in total)
tcn1.local.snellius.surf.nl - Linux RHEL 8.6, x86_64, AMD EPYC 7H12 64-Core Processor, Python 3.6.8
See https://gist.github.com/casparvl/e2c88742dd87756bd2df8d998b02f93f for a full test report.

@casparvl
Copy link
Contributor

Retrying with the buildpath and tmpdir on a different fs, let's see if that helps somehow. The number of timeouts seem to be different between my two runs. Maybe our FS is just not responsive, and that's what's causing the timeouts.

@casparvl
Copy link
Contributor

Test report by @casparvl
FAILED
Build succeeded for 1 out of 2 (2 easyconfigs in total)
tcn1.local.snellius.surf.nl - Linux RHEL 8.6, x86_64, AMD EPYC 7H12 64-Core Processor, Python 3.6.8
See https://gist.github.com/casparvl/d64fb813140c1b2f448295b1260c5599 for a full test report.

@akesandgren
Copy link
Contributor

akesandgren commented Aug 24, 2023

Test report by @akesandgren
FAILED
Build succeeded for 1 out of 2 (2 easyconfigs in total)
b-cn1603.hpc2n.umu.se - Linux Ubuntu 22.04, x86_64, AMD EPYC 7313 16-Core Processor, 1 x NVIDIA NVIDIA A100 80GB PCIe, 525.125.06, Python 3.10.6
See https://gist.github.com/akesandgren/5d206a8c59cc138546fdfe8c45c12b7a for a full test report.

Building with intel on AMD without changing optarch to something that works.... of course it fails.

@akesandgren
Copy link
Contributor

akesandgren commented Aug 24, 2023

Test report by @akesandgren
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
b-cn1603.hpc2n.umu.se - Linux Ubuntu 22.04, x86_64, AMD EPYC 7313 16-Core Processor, 1 x NVIDIA NVIDIA A100 80GB PCIe, 525.125.06, Python 3.10.6
See https://gist.github.com/akesandgren/210ceb602f20884089941cd64e45cbd1 for a full test report.

So, intel-compiler build on AMD with proper optarch, works like a charm.

@boegel
Copy link
Member Author

boegel commented Aug 30, 2023

@casparvl Can you check on those failing test reports again?

@boegel boegel modified the milestones: 4.8.1, release after 4.8.1 Sep 9, 2023
branfosj added a commit to xinan1911/easybuild-easyconfigs that referenced this pull request Sep 10, 2023
@branfosj
Copy link
Member

Test report by @branfosj
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
bear-pg0105u03a.bear.cluster - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/67bf3a0f6595ad53bac72e420a0cf520 for a full test report.

@casparvl
Copy link
Contributor

Test report by @casparvl
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
tcn1.local.snellius.surf.nl - Linux RHEL 8.6, x86_64, AMD EPYC 7H12 64-Core Processor, Python 3.6.8
See https://gist.github.com/casparvl/724bdea50ef7f6bff26c5df5c48667bf for a full test report.

@boegel
Copy link
Member Author

boegel commented Oct 22, 2023

@casparvl ready to merge?

@casparvl casparvl dismissed branfosj’s stale review October 23, 2023 07:46

Suggestions have been implemented

Copy link
Contributor

@casparvl casparvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@casparvl casparvl merged commit 14e17b3 into easybuilders:develop Oct 23, 2023
@boegel boegel deleted the 20230805165141_new_pr_libxc610 branch November 11, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants