Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sanity check for ccache by setting LC_ALL=C #18677

Merged

Conversation

Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Aug 29, 2023

(created using eb --new-pr)

The ldd output being grepped for might be translated which makes the test fail. Disable that by setting LC_ALL

@smoors smoors added the bug fix label Aug 29, 2023
@smoors
Copy link
Contributor

smoors commented Aug 29, 2023

@boegelbot: please test @ generoso

@boegelbot
Copy link
Collaborator

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=18677 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_18677 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11575

Test results coming soon (I hope)...

- notification for comment with ID 1697469234 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/cfe1d2f8a8ffd9ab8477cddbaec35d3a for a full test report.

@smoors
Copy link
Contributor

smoors commented Aug 29, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Collaborator

@smoors: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=18677 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_18677 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3268

Test results coming soon (I hope)...

- notification for comment with ID 1697489673 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/bed3be57754052c16bc93ec648eae15c for a full test report.

@smoors smoors added this to the next release (4.8.1?) milestone Aug 29, 2023
Copy link
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Contributor

smoors commented Aug 29, 2023

Going in, thanks @Flamefire!

@smoors smoors merged commit 13f7e07 into easybuilders:develop Aug 29, 2023
5 checks passed
@Flamefire Flamefire deleted the 20230829123708_new_pr_ccache463 branch August 29, 2023 14:06
@boegel boegel changed the title fix sanity check of ccache fix sanity check for ccache by setting LC_ALL=C Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants