Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{tools}[GCCcore/12.2.0] FPM v1.15.1 w/ Ruby 3.2.2 #19144

Merged

Conversation

PetrKralCZ
Copy link
Collaborator

(created using eb --new-pr)

@boegelbot
Copy link
Collaborator

@PetrKralCZ: Tests failed in GitHub Actions, see https://github.com/easybuilders/easybuild-easyconfigs/actions/runs/6733159382
Output from first failing test suite run:

FAIL: test__parse_easyconfig_FPM-1.15.1-GCCcore-12.2.0-Ruby-3.2.2.eb (test.easyconfigs.easyconfigs.EasyConfigTest)
Test for easyconfig FPM-1.15.1-GCCcore-12.2.0-Ruby-3.2.2.eb
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 1609, in innertest
    template_easyconfig_test(self, spec_path)
  File "/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 1416, in template_easyconfig_test
    "binutils or GCC is a build dep in %s: %s" % (spec, dep_names))
AssertionError: False is not true : binutils or GCC is a build dep in /home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/easybuild/easyconfigs/f/FPM/FPM-1.15.1-GCCcore-12.2.0-Ruby-3.2.2.eb: ['Ruby']

----------------------------------------------------------------------
Ran 18434 tests in 1117.257s

FAILED (failures=1)
ERROR: Not all tests were successful

bleep, bloop, I'm just a bot (boegelbot v20200716.01)
Please talk to my owner @boegel if you notice me acting stupid),
or submit a pull request to https://github.com/boegel/boegelbot fix the problem.

@PetrKralCZ
Copy link
Collaborator Author

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@PetrKralCZ: Request for testing this PR well received on login1

PR test command 'EB_PR=19144 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19144 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12088

Test results coming soon (I hope)...

- notification for comment with ID 1790950404 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/df9c797476900d88848a86608a24235f for a full test report.

@bedroge
Copy link
Contributor

bedroge commented Nov 4, 2023

Test report by @bedroge
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bob-Latitude-5300 - Linux Ubuntu 22.04, x86_64, Intel(R) Core(TM) i7-8665U CPU @ 1.90GHz, Python 3.10.12
See https://gist.github.com/bedroge/676219d29459d949cf13f4344dbc0da2 for a full test report.

@bedroge
Copy link
Contributor

bedroge commented Nov 4, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@bedroge: Request for testing this PR well received on login1

PR test command 'EB_PR=19144 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19144 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12106

Test results coming soon (I hope)...

- notification for comment with ID 1793543013 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/d1fd5ca8e8b290eed6014f5b234d0479 for a full test report.

Copy link
Contributor

@bedroge bedroge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@bedroge bedroge added this to the next release (4.9.0?) milestone Nov 4, 2023
@bedroge
Copy link
Contributor

bedroge commented Nov 4, 2023

Going in, thanks @PetrKralCZ!

@bedroge bedroge merged commit 4b87610 into easybuilders:develop Nov 4, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants