Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use proper dependency for tensorboard in easyconfigs for TensorFlow v2.15.1 #21337

Merged

Conversation

lexming
Copy link
Contributor

@lexming lexming commented Sep 6, 2024

(created using eb --new-pr)

@lexming lexming added the change label Sep 6, 2024
@boegel boegel added this to the 4.x milestone Sep 11, 2024
@boegel
Copy link
Member

boegel commented Sep 11, 2024

@Flamefire Thoughts on this?

@Flamefire
Copy link
Contributor

Haven't checked that all current packages are contained in the tensorboard EC but if they are I see no issue here so that's good for reuse in other ECs. That is if that works with the versions for TensorFlow used in TensorBoard.

@lexming
Copy link
Contributor Author

lexming commented Sep 11, 2024

Sorry I forgot to explain my motivation. The reason for this is to be able to apply fixes for tensorboard without having to rebuild TensorFlow. Specifically #20823. And since we already have a standalone tensorboard it's easy to split it out to simplify the maintenance.

@lexming
Copy link
Contributor Author

lexming commented Sep 11, 2024

@boegelbot: please test @ generoso
EB_ARGS="TensorFlow-2.15.1-foss-2023a.eb"

@boegelbot
Copy link
Collaborator

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=21337 EB_ARGS="TensorFlow-2.15.1-foss-2023a.eb" EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_21337 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14243

Test results coming soon (I hope)...

- notification for comment with ID 2343708761 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns2 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/70e481448c7ec40485b7bbda04c0df64 for a full test report.

@boegel boegel modified the milestones: 4.x, release after 4.9.3 Sep 12, 2024
@boegel boegel changed the title unbundle tensorboard from TensorFlow v2.15.1 use proper dependency for tensorboard in easyconfigs for TensorFlow v2.15.1 Sep 21, 2024
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Sep 21, 2024

@boegelbot: please test @ jsc-zen3-a100
EB_ARGS="TensorFlow-2.15.1-foss-2023a-CUDA-12.1.1.eb"
CORE_CNT=16

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=21337 EB_ARGS="TensorFlow-2.15.1-foss-2023a-CUDA-12.1.1.eb" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_21337 --ntasks="16" --partition=jsczen3g --gres=gpu:1 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4929

Test results coming soon (I hope)...

- notification for comment with ID 2365206591 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel boegel modified the milestones: release after 4.9.4, 4.9.4 Sep 21, 2024
@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3g1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), 1 x NVIDIA NVIDIA A100 80GB PCIe, 555.42.06, Python 3.9.18
See https://gist.github.com/boegelbot/50d06c77b71dd1577ed8e7208f6b6c34 for a full test report.

@boegel
Copy link
Member

boegel commented Sep 21, 2024

Going in, thanks @lexming!

@boegel boegel merged commit 94b1e13 into easybuilders:develop Sep 21, 2024
9 checks passed
@boegel
Copy link
Member

boegel commented Sep 22, 2024

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node3309.joltik.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6242 CPU @ 2.80GHz, 1 x NVIDIA Tesla V100-SXM2-32GB, 545.23.08, Python 3.6.8
See https://gist.github.com/boegel/32facf099f2023d29757318422538c2d for a full test report.

@lexming lexming deleted the 20240906160150_new_pr_TensorFlow2151 branch September 23, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants