Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add patch to fix compilation of HPDBSCAN 20210826 #21467

Merged

Conversation

Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Sep 23, 2024

(created using eb --new-pr)

This became an issue after dropping the numpy includes from the SciPy-bundle module during a module-only rebuild. However the issue is due to a real bug and might hunt us again.

@Flamefire
Copy link
Contributor Author

Test report by @Flamefire
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
n1616 - Linux RHEL 8.9 (Ootpa), x86_64, Intel(R) Xeon(R) Platinum 8470 (icelake), Python 3.8.17
See https://gist.github.com/Flamefire/1c501e8a53bd5ac8d7754ddefc2b33ff for a full test report.

@boegel boegel changed the title Fix compilation of HPDBSCAN add patch to fix compilation of HPDBSCAN Sep 25, 2024
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel added the bug fix label Sep 25, 2024
@boegel boegel added this to the release after 4.9.4 milestone Sep 25, 2024
@boegel boegel changed the title add patch to fix compilation of HPDBSCAN add patch to fix compilation of HPDBSCAN 20210826 Sep 25, 2024
@boegel
Copy link
Member

boegel commented Sep 25, 2024

@boegelbot please test @ generoso

@easybuilders easybuilders deleted a comment from boegelbot Sep 25, 2024
@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=21467 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_21467 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14345

Test results coming soon (I hope)...

- notification for comment with ID 2374878678 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/9d94eeb22f6c83b28d7c0b81dcc031ae for a full test report.

@boegel
Copy link
Member

boegel commented Sep 25, 2024

Going in, thanks @Flamefire!

@boegel boegel merged commit a50f174 into easybuilders:develop Sep 25, 2024
9 checks passed
@Flamefire Flamefire deleted the 20240923091634_new_pr_HPDBSCAN20171110 branch September 26, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants