-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{tools}[gfbf/2023b] Spyder v6.0.1, Deprecated v1.2.14, PyQt-builder v1.16.4, ... #21684
{tools}[gfbf/2023b] Spyder v6.0.1, Deprecated v1.2.14, PyQt-builder v1.16.4, ... #21684
Conversation
…f-2023b.eb, PyQt-builder-1.16.4-GCCcore-13.2.0.eb, PyQt5-5.15.10-GCCcore-13.2.0.eb, Qtconsole-5.6.0-GCCcore-13.2.0.eb, QtPy-2.4.1-GCCcore-13.2.0.eb, Rtree-1.2.0-GCCcore-13.2.0.eb, wrapt-1.16.0-gfbf-2023b.eb
@boegelbot please test @ generoso |
@pavelToman: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2419340360 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
@boegelbot please test @ jsc-zen3 |
@pavelToman: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2419589197 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
Would it make sense to use the same dependencies as in #21653 (and dependent PRs) such that the extracted easyconfigs can be used in other places? That would also bring down the number of extensions installed in the Spyder EC and updating the ECs might be sufficiently easy, at least after merging #21653 I'd also double check the extension list of Spyder with I could help with that if desired. |
@boegelbot please test @ generoso |
easybuild/easyconfigs/t/text-unidecode/text-unidecode-1.3-GCCcore-13.2.0.eb
Outdated
Show resolved
Hide resolved
@pavelToman: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2426516467 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
@boegelbot please test @ jsc-zen3 |
@pavelToman: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2427136093 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
@boegelbot please test @ generoso |
@pavelToman: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2428803682 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
@boegelbot please test @ jsc-zen3 |
@pavelToman: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2429170024 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified the packages against existing EasyConfigs and the findPythonDeps
output. Comments and suggestions inline, tested locally.
Mostly: Lower to GCCcore and use PythonPackage where possible. Not really critical but I think it makes usage and updating later easier
easybuild/easyconfigs/p/python-slugify/python-slugify-8.0.4-GCCcore-13.2.0.eb
Outdated
Show resolved
Hide resolved
easybuild/easyconfigs/p/python-slugify/python-slugify-8.0.4-GCCcore-13.2.0.eb
Outdated
Show resolved
Hide resolved
easybuild/easyconfigs/p/python-slugify/python-slugify-8.0.4-GCCcore-13.2.0.eb
Show resolved
Hide resolved
Co-authored-by: Alexander Grund <Flamefire@users.noreply.github.com>
Co-authored-by: Alexander Grund <Flamefire@users.noreply.github.com>
Co-authored-by: Alexander Grund <Flamefire@users.noreply.github.com>
Co-authored-by: Alexander Grund <Flamefire@users.noreply.github.com>
Co-authored-by: Alexander Grund <Flamefire@users.noreply.github.com>
Co-authored-by: Alexander Grund <Flamefire@users.noreply.github.com>
Co-authored-by: Alexander Grund <Flamefire@users.noreply.github.com>
Thank you @Flamefire for a review and commit suggestions! |
@boegelbot please test @ generoso |
@pavelToman: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2485289988 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
…asyconfigs into 20241017135930_new_pr_Spyder601
… sanity check for Spyder v6.0.1
1ebbde7
to
0250642
Compare
@@ -101,8 +101,10 @@ exts_list = [ | |||
}), | |||
] | |||
|
|||
enhance_sanity_check = True | |||
sanity_check_paths = {'files': ['bin/spyder']} | |||
sanity_check_paths = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@boegel I suggested to use this approach of not repeating default checks when using enhance_sanity_check
as to me it is a bug that the original dirs
is not checked which will be fixed by easybuilders/easybuild-easyblocks#3477
As not having the path will still result in a sanity check failure (import and/or spyder --help) I'd rather not introduce something we have to cleanup later.
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixing the bug is definitely a better approach, I'll take a look at easybuilders/easybuild-easyblocks#3477 ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
easybuilders/easybuild-easyblocks#3477 will need a bit of testing, I won't let that block this PR, we'll need to clean up a bunch of other easyconfigs anyway to use enhance_sanity_check
once that easyblock PR is merged...
…asyconfigs into 20241017135930_new_pr_Spyder601
easybuild/easyconfigs/d/Deprecated/Deprecated-1.2.14-GCCcore-13.2.0.eb
Outdated
Show resolved
Hide resolved
…3.2.0.eb Co-authored-by: Alexander Grund <Flamefire@users.noreply.github.com>
Test report by @boegel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Going in, thanks @pavelToman! |
(created using
eb --new-pr
)resolves vscentrum/vsc-software-stack#431
requierd: