Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{tools}[gfbf/2023b] Spyder v6.0.1, Deprecated v1.2.14, PyQt-builder v1.16.4, ... #21684

Merged

Conversation

pavelToman
Copy link
Collaborator

@pavelToman pavelToman commented Oct 17, 2024

…f-2023b.eb, PyQt-builder-1.16.4-GCCcore-13.2.0.eb, PyQt5-5.15.10-GCCcore-13.2.0.eb, Qtconsole-5.6.0-GCCcore-13.2.0.eb, QtPy-2.4.1-GCCcore-13.2.0.eb, Rtree-1.2.0-GCCcore-13.2.0.eb, wrapt-1.16.0-gfbf-2023b.eb
@pavelToman
Copy link
Collaborator Author

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@pavelToman: Request for testing this PR well received on login1

PR test command 'EB_PR=21684 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_21684 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14506

Test results coming soon (I hope)...

- notification for comment with ID 2419340360 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@pavelToman pavelToman changed the title {tools,vis}[GCCcore/13.2.0] Spyder v6.0.1, Deprecated v1.2.14, PyQt-builder v1.16.4, ... {tools}[gfbf/2023b] Spyder v6.0.1, Deprecated v1.2.14, PyQt-builder v1.16.4, ... Oct 17, 2024
@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 8 out of 8 (8 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/d999934e9965fe8abf08537b1a7a3a41 for a full test report.

@pavelToman
Copy link
Collaborator Author

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@pavelToman: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=21684 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_21684 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5111

Test results coming soon (I hope)...

- notification for comment with ID 2419589197 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 8 out of 8 (8 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/f279a1aa48c7e41fc6e9935066f69b86 for a full test report.

@Flamefire
Copy link
Contributor

Would it make sense to use the same dependencies as in #21653 (and dependent PRs) such that the extracted easyconfigs can be used in other places? That would also bring down the number of extensions installed in the Spyder EC and updating the ECs might be sufficiently easy, at least after merging #21653

I'd also double check the extension list of Spyder with findPythonDeps using the fixed version from easybuilders/easybuild-framework#4682

I could help with that if desired.

@pavelToman
Copy link
Collaborator Author

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@pavelToman: Request for testing this PR well received on login1

PR test command 'EB_PR=21684 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_21684 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14548

Test results coming soon (I hope)...

- notification for comment with ID 2426516467 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 15 out of 15 (15 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/36047f4dd20dd73d097c8b11aa80360c for a full test report.

@pavelToman
Copy link
Collaborator Author

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@pavelToman: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=21684 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_21684 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5142

Test results coming soon (I hope)...

- notification for comment with ID 2427136093 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 15 out of 15 (15 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/1661b1081727094f6cc80a740154d522 for a full test report.

@pavelToman
Copy link
Collaborator Author

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@pavelToman: Request for testing this PR well received on login1

PR test command 'EB_PR=21684 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_21684 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14551

Test results coming soon (I hope)...

- notification for comment with ID 2428803682 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 15 out of 15 (15 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/2e4ec6de9a6b10fe8b65217710bc4e08 for a full test report.

@pavelToman
Copy link
Collaborator Author

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@pavelToman: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=21684 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_21684 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5146

Test results coming soon (I hope)...

- notification for comment with ID 2429170024 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 15 out of 15 (15 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/bb407e253c88221a2be1d8e2603df9c8 for a full test report.

Copy link
Contributor

@Flamefire Flamefire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified the packages against existing EasyConfigs and the findPythonDeps output. Comments and suggestions inline, tested locally.

Mostly: Lower to GCCcore and use PythonPackage where possible. Not really critical but I think it makes usage and updating later easier

pavelToman and others added 7 commits November 19, 2024 11:20
Co-authored-by: Alexander Grund <Flamefire@users.noreply.github.com>
Co-authored-by: Alexander Grund <Flamefire@users.noreply.github.com>
Co-authored-by: Alexander Grund <Flamefire@users.noreply.github.com>
Co-authored-by: Alexander Grund <Flamefire@users.noreply.github.com>
Co-authored-by: Alexander Grund <Flamefire@users.noreply.github.com>
Co-authored-by: Alexander Grund <Flamefire@users.noreply.github.com>
Co-authored-by: Alexander Grund <Flamefire@users.noreply.github.com>
@pavelToman
Copy link
Collaborator Author

Thank you @Flamefire for a review and commit suggestions!

@pavelToman
Copy link
Collaborator Author

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@pavelToman: Request for testing this PR well received on login1

PR test command 'EB_PR=21684 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_21684 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14739

Test results coming soon (I hope)...

- notification for comment with ID 2485289988 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 14 out of 15 (15 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/e2f23c862938c58903f055883a122422 for a full test report.

@github-actions github-actions bot added the new label Dec 10, 2024
@pavelToman pavelToman removed the new label Dec 10, 2024
@boegel boegel force-pushed the 20241017135930_new_pr_Spyder601 branch from 1ebbde7 to 0250642 Compare December 11, 2024 07:08
@github-actions github-actions bot added the new label Dec 11, 2024
@@ -101,8 +101,10 @@ exts_list = [
}),
]

enhance_sanity_check = True
sanity_check_paths = {'files': ['bin/spyder']}
sanity_check_paths = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel I suggested to use this approach of not repeating default checks when using enhance_sanity_check as to me it is a bug that the original dirs is not checked which will be fixed by easybuilders/easybuild-easyblocks#3477

As not having the path will still result in a sanity check failure (import and/or spyder --help) I'd rather not introduce something we have to cleanup later.

What do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing the bug is definitely a better approach, I'll take a look at easybuilders/easybuild-easyblocks#3477 ...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easybuilders/easybuild-easyblocks#3477 will need a bit of testing, I won't let that block this PR, we'll need to clean up a bunch of other easyconfigs anyway to use enhance_sanity_check once that easyblock PR is merged...

…3.2.0.eb

Co-authored-by: Alexander Grund <Flamefire@users.noreply.github.com>
@boegel
Copy link
Member

boegel commented Jan 14, 2025

Test report by @boegel
SUCCESS
Build succeeded for 15 out of 15 (15 easyconfigs in total)
node3101.skitty.os - Linux RHEL 9.4, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.9.18
See https://gist.github.com/boegel/245a9ee6ca61642ab85e65393f10d38b for a full test report.

@boegel boegel modified the milestones: 4.x, release after 4.9.4 Jan 14, 2025
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Jan 14, 2025

Going in, thanks @pavelToman!

@boegel boegel merged commit e842030 into easybuilders:develop Jan 14, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spyder
4 participants