Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable automatic style checks in easyconfig tests #2506

Merged
merged 9 commits into from
Jun 22, 2017

Conversation

wpoely86
Copy link
Member

@wpoely86 wpoely86 commented Feb 17, 2016

@hpcugentbot
Copy link
Contributor

Easyconfigs unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6273/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

* develop: (91 commits)
  consistently use %(perlver)s
  disable optarch toolchain option to dance around internal compiler error
  additional style fixes in xtrans easyconfigs
  additional style fixes in TCC, Vampir, VampirServer and ViennaRNA easyconfigs
  Don't use %(perl)s and add Perl as a dep.
  additional style fixes in psmpi easyconfigs
  additional style fixes in Python easyconfigs
  additional style fixes in ParMETIS easyconfigs
  add comments in patch files
  {vis}[intel/2016a] PyFFmpeg 2.1beta + FFmpeg 0.10.16
  additional style fixes in OpenFOAM easyconfigs
  additional style fixes in Oger easyconfigs
  additional style fixes in nettle easyconfigs
  additional style fixes in ncurses easyconfigs
  additional style fixes in NCO easyconfigs
  additional style fixes in MultiNest easyconfigs
  additional style fixes in MCR easyconfigs
  Use of source name template
  Messing w/ the %s vs %%(perl)s style interpolation.
  Use Perl suffix and factor out 'kmer'
  ...
@boegel boegel added this to the v2.7.0 milestone Feb 24, 2016
@boegel boegel modified the milestones: v2.7.0, v2.8.0 Mar 11, 2016
@boegel boegel modified the milestones: v2.8.0, v2.9.0 May 10, 2016
@boegel boegel modified the milestones: 3.0, v2.9.0 Sep 19, 2016
@boegel boegel modified the milestones: 3.0, 3.1 Nov 14, 2016
@boegel boegel mentioned this pull request Nov 29, 2016
* develop: (3139 commits)
  adding easyconfigs: Spark-2.0.2.eb
  bump version (again) to 3.1.0.dev0
  adding easyconfigs: EasyBuild-3.0.1.eb
  adding easyconfigs: ccache-3.3.3.eb
  bump version to v3.0.1
  include easybuilders#3826, update counts
  include easybuilders#3858 in release notes for EasyBuild v3.0.1
  fix release notes for eb301
  prepare release notes for eb301
  Rewrite sanity_check_commands to specify a string and use a glob
  adding easyconfigs: BBMap-36.62-intel-2016b-Java-1.8.0_112.eb
  change order or dependencies
  adding easyconfigs: BLAST-2.2.26-Linux_x86_64.eb
  Add example input files to sanity_check
  adding easyconfigs: findhap-4.eb
  Update Boost-1.61.0-foss-2016b-Python-2.7.12.eb
  Remove unwanted build artefacts and outdated comment re upstream Cufflinks/Boost bug
  adding easyconfigs: PhyloBayes-MPI-20161021-intel-2016b.eb
  Fix missing " "
  Remove redundant depenedncies.
  ...
include count of easyconfigs that fail style check in error message
@boegel boegel mentioned this pull request Dec 1, 2016
@boegel boegel modified the milestones: 3.1.0, 3.2.0 Feb 1, 2017
@boegel
Copy link
Member

boegel commented Jun 21, 2017

@wpoely86 Please update this with current develop, Travis should give the green light for all easyconfigs now style-wise (thanks to #4761 - #4764)...

* origin/develop: (1311 commits)
  avoid hardcoding stripping of 'a' (hat tip @vanzod)
  avoid use of 'import' in BFAST easyconfigs, just strip of 'a' from version
  set $OMP_NUM_THREADS during CP2K test step via dedicated easyconfig parameter
  avoid use of import in ANSYS & MATLAB easyconfigs
  more trivial style fixes
  style fix
  adding easyconfigs: SAMtools-1.5-intel-2017a.eb
  clean up commented out configopts in DBD-mysql easyconfig
  get rid of tabs
  adding easyconfigs: DBD-mysql-4.042-intel-2017a-Perl-5.24.1.eb, MariaDB-10.1.24-intel-2017a.eb, Perl-5.24.1-intel-2017a.eb
  fix gsoap version numbering
  gsoap: fix source_urls and bump version to 2.8.48
  fix style nits
  fix build dependencies
  delete comment
  install gtest, gSOAP, davix
  install gSOAP
  adding easyconfigs: pydlpoly-20150225-intel-2016b-Python-2.7.12.eb, FFTW-2.1.5-intel-2016b.eb
  adding easyconfigs: CMake-3.8.2-GCCcore-6.3.0.eb
  adding easyconfigs: Rust-1.18.0-foss-2017a.eb
  ...
@boegel boegel changed the title Use Style test from framework to check easyconfigs enable automatic style checks in easyconfig tests Jun 22, 2017
@boegel
Copy link
Member

boegel commented Jun 22, 2017

Finally going in, thanks for your efforts on this @wpoely86 and also @migueldiascosta for the many style fixing PRs!

@boegel boegel merged commit 37ca2b0 into easybuilders:develop Jun 22, 2017
@wpoely86 wpoely86 deleted the style-new branch June 22, 2017 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants