-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add missing libX dependencies for cairo #2630
Conversation
Test report by @boegel |
Test report by @boegel |
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6786/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
@boegel: mayve we have to explicitly add |
@hajgato: makes sense, will do, thanks for the suggestion |
@boegel: builddependencies = [
('renderproto', '0.11'),
] |
Test report by @boegel |
Test report by @boegel |
@hajgato: ok, will add that too |
('libXrender', '0.9.9'), | ||
('libXext', '1.3.3'), | ||
] | ||
builddependencies = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
above dependencies?
extra empty line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have strict guidelines for this imho..
I think you'll find all combos w.r.t. order and empty line in between or not.
Let's change this consistently once we have an automated check for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, then. :)
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6787/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6788/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6789/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
Thanks for the review @hajgato! |
add missing libX dependencies for cairo
When looking into adding support for Glade, I ran into missing dependencies for cairo~~, and some misspecified build deps in X11 libraries that should actually be runtime dependencies (as specified in the pkg-config files for these libraries).~~
The latter was changed in the latest2016
easyconfigs for the X11 libraries done by @hajgato (cfr. #2549, #2563, #2614)