style fixes #266
Merged
style fixes #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ('lockfile', '0.9.1', { | ||
| 'source_urls': ['http://pylockfile.googlecode.com/files/'], | ||
| }), | ||
| ('Cython', '0.17.2', { |
There was a problem hiding this comment.
I don't see this in the source above, but I see it in another easyconfig of Python (Python-2.7.3-ictce-4.1.13.eb); just be aware of it, it might be desired or not so. Ditto for the other Python easyconfigs; other than that I didn't see something else raising attention.
There was a problem hiding this comment.
I was there in certain Python easyconfigs, but not in others, I wanted to align things to make them include the same set of extensions.
Adding an extension is OK, imho (as opposed to removing one).
Conflicts: test/easyconfigs/suite.py
boegel
pushed a commit
that referenced
this pull request
Aug 14, 2020
fix typo in source_urls for NAMD 2.14: %(versin)s -> %(version)s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.