-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R 3.5.0 for iomkl 2018a #6466
R 3.5.0 for iomkl 2018a #6466
Conversation
Hi @boegel - so what would you like me to do with this PR? |
@edmondac I think we should either update the extensions as well, or abandon this... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edmondac Thanks a lot for looking into updating the extension versions... How did you go about this, did you go through them manually, or using some script?
|
||
name = 'libGLU' | ||
version = '9.0.0' | ||
versionsuffix = '-Mesa-17.3.6' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edmondac This is basically the same as the existing libGLU-9.0.0-iomkl-2018a.eb
, so I don't see the point?
Just use ('libGLU', '9.0.0')
in the R
easyconfig instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry - missed that one. I'd changed the dep but not removed the file.
homepage = 'http://trac.osgeo.org/geos' | ||
description = """GEOS (Geometry Engine - Open Source) is a C++ port of the Java Topology Suite (JTS)""" | ||
|
||
toolchain = {'name': 'iomkl', 'version': '2018a'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This easyconfig isn't actually required to resolve a dependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point - removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated using easy_update, then a little tinkering.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's still building here with the updated apps, it's about half way through them...
'checksums': ['49da299139a47171c5b4ccdea79ffbbc152894e05d552e676f135147c0c9b372'], | ||
}), | ||
('clValid', '0.6-6', { | ||
'checksums': ['bcf781238a2a831a7ec8909d27251731e3115a0541a9ea9795e5ec4d903938d1'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edmondac I'm getting a different checksum here: c13ef1b6258e34ba53615b78f39dbe4d8ba47b976b3c24a3eedaecf5ffba19ed
(fresh download)...
I've fixed the checksum - they must have changed the tgz. I reverted RSQLite to 2.0 because I didn't feel like I had time to make a new patch - since RSQLite-2.0-icc.patch doesn't apply any more. I've just reverted randomForestSRC too as the new one segfaults (like randomForest) with iomkl 2018a Building again here... I'll let you know when it completes... |
… patch for matrixStats, fix checksum for penalized, update patch for imager, add gee extension
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edmondac all suggestions are tackled in bear-rsg#1, if you merge that PR this one will be updated accordingly, and then it should be good to go
} | ||
|
||
# !! order of packages is important !! | ||
# packages updated on Mar 15 2018 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edmondac Please fix this date
('GMP', '6.1.2'), # for igraph | ||
('NLopt', '2.4.2'), # for nloptr | ||
('FFTW', '3.3.7'), # for fftw | ||
('libsndfile', '1.0.28'), # for seewave |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing ICU
dependency, see #6371
('formatR', '1.5', { | ||
'checksums': ['874c197ae3720ec11b44984a055655b99a698e1912104eb9034c11fdf6104da7'], | ||
}), | ||
('gtools', version, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edmondac this should say '3.5.0'
, not version
(probably a side effect of using easy_update
?)
'checksums': ['bcf781238a2a831a7ec8909d27251731e3115a0541a9ea9795e5ec4d903938d1'], | ||
}), | ||
('matrixStats', '0.53.1', { | ||
'checksums': ['df70bc9fb64716a7a633b5d0c2a2422b2c8d93ac5e64574528a325505df9712e'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
patch is missing here, see #6278
'checksums': ['c007d6eaf6335a15c1912b0804276ff39abce27b7a61539a91b8fda653629252'], | ||
}), | ||
('penalized', '0.9-50', { | ||
'checksums': ['66ed84b967f70fd49702318e43e129c2ff60bb0631b81fe2617671d1ebbbc060'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this checksum is also wrong, should be c12b3259e019f91c7bd02827ea3a27f842d9c15950fa6cc114dff23c89c297d1
, see also #6083 (comment)
'checksums': [ | ||
'fc9ba74519388c194e14bae39d41f3fec8c2aade0177df364f61753f0fbf8a3d', # glasso_1.8.tar.gz | ||
'87e966b6651c2d9ccd8a2c2ba842eef8dcbeaa3fdd25085bb1d5aff6e79f409c', # glasso-1.8-ifort-no-fixed.patch | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing extension: gee
(cfr. #6376)
'checksums': [ | ||
'fc9ba74519388c194e14bae39d41f3fec8c2aade0177df364f61753f0fbf8a3d', # glasso_1.8.tar.gz | ||
'87e966b6651c2d9ccd8a2c2ba842eef8dcbeaa3fdd25085bb1d5aff6e79f409c', # glasso-1.8-ifort-no-fixed.patch | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this patch no longer applies...
'checksums': [ | ||
'fc9ba74519388c194e14bae39d41f3fec8c2aade0177df364f61753f0fbf8a3d', # glasso_1.8.tar.gz | ||
'87e966b6651c2d9ccd8a2c2ba842eef8dcbeaa3fdd25085bb1d5aff6e79f409c', # glasso-1.8-ifort-no-fixed.patch | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gee
extension is missing (cfr. #6376)
fixes for R-3.5.0-iomkl-2018a-X11-20180131.eb
Test report by @boegel |
Test report by @boegel |
Test report by @boegel |
Going in, thanks @edmondac! |
Here's our R 3.5.0 using iomkl 2018a. I don't know if you'd rather this came with 2018.02...?
It's still building here to test, but I wanted to ask that question sooner rather than later!
This PR is a prerequisite for Bioconductor 3.7, which has at least one library that requires R 3.5.0.