Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{toolchain}[dummy/dummy] goblf v2019a (REVIEW) #8300

Conversation

migueldiascosta
Copy link
Member

@migueldiascosta migueldiascosta commented May 13, 2019

(created using eb --new-pr)

couldn't find existing easyconfigs for the goblf toolchain created by @bartoldeman, this seems to follow the definition (?). In particular, the definition uses LAPACK, I wanted to try using libFLAME, can I change this toolchain definition or shall I define a new gobff (?) toolchain?

There also exists already a linalg/flame definition created by @stdweird which doesn't seem to be used anythere (?), can I change it to use the libFLAME easyconfigs or shall I define a new linalg/libflame?

…PL-2.3-goblf-2019a.eb, LAPACK-3.8.0-gompi-2019a.eb, ScaLAPACK-2.0.2-gompi-2019a-BLIS-0.5.2.eb
@migueldiascosta migueldiascosta changed the title {numlib}[gompi/2019a] BLIS v0.5.2, goblf v2019a, HPL v2.3, ... {toolchain}[dummy/dummy] goblf v2019a (REVIEW) May 13, 2019
@boegelbot
Copy link
Collaborator

Travis test report: 2/2 runs failed - see https://travis-ci.org/easybuilders/easybuild-easyconfigs/builds/531574602

Only showing partial log for 1st failed test suite run 15002.2;
full log at https://travis-ci.org/easybuilders/easybuild-easyconfigs/jobs/531574604

...
FAIL: test_dep_versions_per_toolchain_generation (test.easyconfigs.easyconfigs.EasyConfigTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/easybuilders/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 313, in test_dep_versions_per_toolchain_generation
    self.assertFalse(multi_dep_vars, error_msg)
AssertionError: No multi-variant deps found for '^.*-(?P<tc_gen>201[89][ab]).*\.eb$' easyconfigs:

found 2 variants of 'ScaLAPACK' dependency in easyconfigs using '2019a' toolchain generation
* version: 2.0.2; versionsuffix: -BLIS-0.5.2 as dep for set(['goblf-2019a.eb'])
* version: 2.0.2; versionsuffix: -OpenBLAS-0.3.5 as dep for set(['foss-2019a.eb', 'fosscuda-2019a.eb'])


----------------------------------------------------------------------
Ran 11383 tests in 641.159s

FAILED (failures=1)
ERROR: Not all tests were successful.

*bleep, bloop, I'm just a bot (boegelbot v20180813.01)*Please talk to my owner @boegel if you notice you me acting stupid),or submit a pull request to https://github.com/boegel/boegelbot fix the problem.

@migueldiascosta
Copy link
Member Author

Test report by @migueldiascosta
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in this PR)
sms - Linux centos linux 7.6.1810, AMD EPYC 7601 32-Core Processor, Python 2.7.5
See https://gist.github.com/7c2553bbfdbe360c06018e0be89f1b14 for a full test report.

simultaneous linear equations, least-squares solutions of linear systems of equations, eigenvalue
problems, and singular value problems."""

toolchain = {'name': 'gompi', 'version': '2019a'}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm... I updated an existing easyconfig but I don't see why LAPACK should be at gompi instead of GCC level...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed @migueldiascosta please look at #6615.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, now that you mention that PR, I recall having seen it before, should have looked for it...

@boegel boegel added this to the 3.x milestone May 13, 2019
@bartoldeman bartoldeman self-assigned this May 14, 2019
@migueldiascosta
Copy link
Member Author

Test report by @migueldiascosta
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in this PR)
sms - Linux centos linux 7.6.1810, AMD EPYC 7601 32-Core Processor, Python 2.7.5
See https://gist.github.com/3828b65deb05cbbc32afa9c160ca1065 for a full test report.

@bartoldeman
Copy link
Contributor

we have the same issue as in #6615 in the test suite... we'll need to fix that too. The code is fairly complex.

@migueldiascosta
Copy link
Member Author

updating on my initial comments, I now also have a gobff toolchain definition, using libFLAME instead of LAPACK, which requires either a modified linalg/flame.py or a new linalg/libflame.py, and also requires a slightly modified scalapack easyblock.

I also have an amd toolchain which right now is basically identical to gobff, except that in the easyconfigs I use the AMD forks of BLIS and libFLAME, but my goal would be to add more, e.g. it would be useful to integrate AMD LibM

I'm saying this here because I'd like to know if I'm missing something and what, if anything, people think is worth contributing and in which variants, I'll open separate PRs if there is any interest.

@boegelbot
Copy link
Collaborator

Travis test report: 2/2 runs failed - see https://travis-ci.org/easybuilders/easybuild-easyconfigs/builds/532285596

Only showing partial log for 1st failed test suite run 15070.1;
full log at https://travis-ci.org/easybuilders/easybuild-easyconfigs/jobs/532285597

...
FAIL: test_dep_versions_per_toolchain_generation (test.easyconfigs.easyconfigs.EasyConfigTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/easybuilders/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 313, in test_dep_versions_per_toolchain_generation
    self.assertFalse(multi_dep_vars, error_msg)
AssertionError: No multi-variant deps found for '^.*-(?P<tc_gen>201[89][ab]).*\.eb$' easyconfigs:

found 2 variants of 'ScaLAPACK' dependency in easyconfigs using '2019a' toolchain generation
* version: 2.0.2; versionsuffix: -BLIS-0.5.2 as dep for set(['goblf-2019a.eb'])
* version: 2.0.2; versionsuffix: -OpenBLAS-0.3.5 as dep for set(['foss-2019a.eb', 'fosscuda-2019a.eb'])


----------------------------------------------------------------------
Ran 11401 tests in 1090.247s

FAILED (failures=1)
ERROR: Not all tests were successful.

*bleep, bloop, I'm just a bot (boegelbot v20180813.01)*Please talk to my owner @boegel if you notice you me acting stupid),or submit a pull request to https://github.com/boegel/boegelbot fix the problem.

@boegel boegel modified the milestones: 3.x, 4.x Feb 20, 2020
@migueldiascosta
Copy link
Member Author

superseded by #11761

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants