-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{bio}[system/system] nullarbor v2.0.20191013 #9778
{bio}[system/system] nullarbor v2.0.20191013 #9778
Conversation
Test report by @migueldiascosta |
('Miniconda3', '4.7.10', '', True) | ||
] | ||
|
||
sanity_check_commands = [('nullarbor.pl', '-h')] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is nullarbor.pl --check
, but if fails with missing databases, should those also be installed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@migueldiascosta Thx for pointing --check
option. I think it's a duplicate feature as sanity_check
checks dir /perl5
which contains perl
modules, files
checks all binaries.
You probably are right, a more explicit option can be invoked to check each required perl
modules.
A complete nullarbor
has two parts framework
and dataset
, this easyconfig only cater framework
part. Given the reference database
is of a reasonable size 24G
altogether and different research may use different reference databases, I would prefer to leave this part to the individual institution. I can append a few lines of instructions at the end, see what you @migueldiascosta think.
Ping @migueldiascosta can we merge this PR? Thx |
Sorry for the delayed response, with reference to my comment in #10708, we will decline conda-packages in the upstream easyconfig repo. |
I might think this one may suit for conda contrib, as the source build is quite finicky on dep chains. See how you think. |
(created using
eb --new-pr
)