Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate post_install_step, rename it to post_processing_step #4656

Open
ocaisa opened this issue Sep 25, 2024 · 1 comment
Open

Deprecate post_install_step, rename it to post_processing_step #4656

ocaisa opened this issue Sep 25, 2024 · 1 comment
Assignees
Labels
Milestone

Comments

@ocaisa
Copy link
Member

ocaisa commented Sep 25, 2024

When trying to create a post_install_hook for CUDA, I noticed that the easyblock already has a post_install_step that I didn't want to interfere with. The next opportunity to apply the hook was unclear and in fact is post_postproc_hook, which would be much clearer if the post_install_step had the more accurate name post_processing_step (I'm paraphrasing @boegel from Slack here, so he can correct me if I misrepresent the discussion)

@ocaisa ocaisa added the EasyBuild-5.0 EasyBuild 5.0 label Sep 25, 2024
@boegel boegel added this to the 5.0 milestone Oct 8, 2024
@boegel boegel moved this to Breaking changes in EasyBuild v5.0 Oct 8, 2024
@boegel boegel added the change label Oct 9, 2024
@boegel
Copy link
Member

boegel commented Nov 6, 2024

@bartoldeman Can you take a look at this one?

@bartoldeman bartoldeman self-assigned this Nov 22, 2024
bartoldeman added a commit to bartoldeman/easybuild-framework that referenced this issue Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Breaking changes
Development

No branches or pull requests

3 participants