-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add review pr option #1005
Feature/add review pr option #1005
Conversation
Automatic reply from Jenkins: Can I test this? |
Jenkins: ok to test |
@@ -858,6 +859,39 @@ def resolve_template(value, tmpl_dict): | |||
|
|||
return value | |||
|
|||
def find_relevant_easyconfigs(path, ec): | |||
""" | |||
Find relevant easyconfigs for ec in path based on a simple heuristic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
briefly explain the heuristic used, rename function to find_relatd_easyconfigs
# along with EasyBuild. If not, see <http://www.gnu.org/licenses/>. | ||
# # | ||
""" | ||
Review module for pull requests on the easyconfigs repo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please expand the above; I was compelled to ask Ken on what is this about, so, here are some ideas:
[10:39:11] <boegel> fotis2: --review-pr 123 # will compare all easyconfigs touched in PR #123 with current develop, and give an enhanced diff report
[10:39:59] <boegel> fotis2: for each easyconfigs, it will try and find a set of closely related easyconfigs (some software + e.g. same version + toolchain name), and show the differences in a summary view
Current version can't handle easyconfigs that were deleted (which shouldn't occur, but fine):
I'm also not sure what the |
if not isinstance(ec, EasyConfig): | ||
# we can safely only take the first one | ||
easyconfigs = process_easyconfig(ec, parse_only=True) | ||
if len(easyconfigs) > 1: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't looked at the rest of the code, so maybe this is redundant:
wouldn't not ==1
do the job better, to catch the empty case?
overall good, thanks for the PR! |
use
./eb --review-pr 1017 -D | less -R
to try this out.TODO: