don't modify values of 'paths' list passed as argument to prepend_paths #1300
Conversation
| @@ -226,18 +226,21 @@ def prepend_paths(self, key, paths, allow_abs=False): | |||
| self.log.debug("Wrapping %s into a list before using it to prepend path %s" % (paths, key)) | |||
| paths = [paths] | |||
|
|
|||
| for i, path in enumerate(paths): | |||
There was a problem hiding this comment.
so, we were changing the list while iterating over it? 👎
There was a problem hiding this comment.
we were updating elements in a list while iterating over it, which is OK
What's not OK is that we're modifying the list that is being passed to this method...
|
Refer to this link for build results (access rights to CI server needed): This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Going in, thanks @wpoely86 for the review! |
don't modify values of 'paths' list passed as argument to prepend_paths
…ply easybuilders#1300 fix to ModuleGeneratorLua)
I ran into this issue when using the updated
PythonPackageeasyblock from easybuilders/easybuild-easyblocks#628....