hotfixes for bugs in develop #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icc, EasyBuild was exiting when no easyblock was found instead of falling back to Application class as a default
|
ran into these bugs when running a regression test, so merging these in as hotfixes |
| @@ -1589,7 +1589,7 @@ def get_class(easyblock, log, name=None): | |||
| except ImportError, err: | |||
| # No easyblock could be found, so fall back to default class. | |||
|
|
|||
| log.error("Failed to import easyblock for %s, falling back to default %s class: erro: %s" % \ | |||
There was a problem hiding this comment.
Should at least be warning?
There was a problem hiding this comment.
Fixed in 568e3aa, coming up in a future pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bugs introduced in #106 and #87.
EB_ifort was using incorrect class for icc;
EasyBuild was exiting when no easyblock was found instead of falling back to Application class as a default