Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove reload statements in include.py, since they are not required and break --include-toolchains #1679

Merged
merged 2 commits into from
Mar 19, 2016

Conversation

boegel
Copy link
Member

@boegel boegel commented Mar 18, 2016

fix for issue reported in #1677 by @chrisacbr

The changes in the tests are required to trigger the bug being fixed.

@hpcugentbot
Copy link
Contributor

EasyBuild framework unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2884/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

@boegel
Copy link
Member Author

boegel commented Mar 18, 2016

Jenkins: test this please

@hpcugentbot
Copy link
Contributor

EasyBuild framework unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2885/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

@boegel
Copy link
Member Author

boegel commented Mar 18, 2016

Jenkins: test this please

@hpcugentbot
Copy link
Contributor

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2886/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Member Author

boegel commented Mar 19, 2016

Fix is confirmed by @chrisacbr in #1677, and also by @ocaisa and @gppezzi, so going in.

Thanks for your help in figuring this out @ocaisa!

boegel added a commit that referenced this pull request Mar 19, 2016
remove reload statements in include.py, since they are not required and break --include-toolchains
@boegel boegel merged commit 51dece4 into easybuilders:develop Mar 19, 2016
@boegel boegel deleted the fix_include branch March 19, 2016 08:23
boegel added a commit to boegel/easybuild-framework that referenced this pull request Mar 19, 2016
boegel added a commit to boegel/easybuild-framework that referenced this pull request Mar 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants