Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix type conversion for checksums #1840

Merged
merged 2 commits into from
Jul 11, 2016
Merged

Conversation

boegel
Copy link
Member

@boegel boegel commented Jul 9, 2016

@Caylo I noticed that the case of a single checksum being listed as [('md5', '...')] got broken with #1826, we'll need to fix that since this introduces a regression and breaks a handful of existing easyconfigs, e.g. https://github.com/hpcugent/easybuild-easyconfigs/blob/master/easybuild/easyconfigs/c/CUDA/CUDA-6.5.14.eb and https://github.com/hpcugent/easybuild-easyconfigs/blob/master/easybuild/easyconfigs/c/CAP3/CAP3-20071221-intel-x86_64.eb, resulting in errors like:

== 2016-07-09 22:09:04,289 easyblock.py:2519 INFO Running source_checksum_step step
== 2016-07-09 22:09:04,289 filetools.py:463 DEBUG Using blocksize 16777216 for calculating the checksum
== 2016-07-09 22:09:06,276 filetools.py:502 DEBUG Computed md5 checksum for /user/data/gent/vsc400/vsc40023/EasyBuild/sources/c/CUDA/cuda_6.5.14_linux_64.run: 90b1b8f77313600cc294d9271741f4da (correct checksum: md5)
== 2016-07-09 22:09:06,361 build_log.py:152 ERROR Checksum verification for /user/data/gent/vsc400/vsc40023/EasyBuild/sources/c/CUDA/cuda_6.5.14_linux_64.run using ['md5', '90b1b8f77313600cc294d9271741f4da'] failed. (at easybuild/framework/easyblock.py:1489 in checksum_step)

please fix? :)

@boegel boegel added this to the v2.8.2 milestone Jul 9, 2016
@boegel boegel changed the title fix type conversion for checksums (WIP) fix type conversion for checksums Jul 11, 2016
@boegel boegel merged commit ca330ba into easybuilders:develop Jul 11, 2016
@boegel boegel deleted the fix_to_checksums branch July 11, 2016 12:35
boegel added a commit to boegel/easybuild-framework that referenced this pull request Jul 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant