-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ingest vsc-base & vsc-install #2708
Conversation
…nality from easybuild.base.missing
…d.tools.systemtools
…from easybuild.base.missing
Some further clarification w.r.t. my motivation to ingest
|
"vsc-install >= 0.9.19", | ||
"vsc-base >= 2.5.8", | ||
], | ||
install_requires=['setuptools >= 0.6'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so where are we still using it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
setuptools
is still used for now, yes, that needs more work
It's big but I didn't find anything that caught my attention. |
|
||
|
||
class LoggedException(Exception): | ||
"""Exception that logs it's message when it is created.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its
This set of changes basically ingests
vsc-base
&vsc-install
into the EasyBuild framework, either by copying the modules from thevsc.utils
namespace intoeasybuild.base
, or by copying the functionality into an existing module in theeasybuild.tools
namespace.As such, this effectively removes
vsc-base
andvsc-install
as dependencies.I tried to only make minimal changes to the code being copied in, this is mostly about making the EasyBuild framework independent from
vsc-base
, not about also cleaning up that code. Therefore, any complaints made by Hound CI will be ignored.I did strip out a bunch of code from the
vsc-base
modules that is currently not required by the EasyBuild framework.Once this change is merged, we can start working on making EasyBuild compatible with Python 3.
Note that the target branch here is
4.x
(which was forked from the currentdevelop
branch), so these changes will only be included in EasyBuild 4.0.It's quite likely there will be one or more 3.x releases (e.g. 3.8.1, 3.9.0) before 4.0 is released.
The current
develop
branch remains the right place for changes that should be included in the next EasyBuild (3.x) release. I'll keep an eye on mergingdevelop
into the4.x
branch on a regular basis.