enhance log_file_format to fix problem when %(name)s template value is used for log directory #2818

boegel · 2019-03-22T09:53:14Z

fixes #2815

…s used for log directory

test/framework/config.py

ocaisa

Tested and works as expected, just the config option in the tests needs to be corrected

boegel · 2019-03-22T12:40:52Z

kicking Travis now #2819 is merged which fixes the problems with the bootstrap script...

boegel added 3 commits March 22, 2019 10:18

enhance log_file_format to fix problem when %(name)s template value i…

269ccee

…s used for log directory

add tests for log_file_format, get_log_filename and log_path functions

bad19f0

minor code cleanup in log_file_format

1f58af9

boegel added the bug fix label Mar 22, 2019

boegel added this to the next release (3.8.2) milestone Mar 22, 2019

boegel requested a review from ocaisa March 22, 2019 09:53

boegel mentioned this pull request Mar 22, 2019

Can't use string templates such as %(name)s in the DIR part of --logfile-format #2815

Closed

ocaisa reviewed Mar 22, 2019

View reviewed changes

test/framework/config.py Outdated Show resolved Hide resolved

ocaisa requested changes Mar 22, 2019

View reviewed changes

make sure --logfile-format setting is correct, should be a 2-tuple

884413b

ocaisa approved these changes Mar 22, 2019

View reviewed changes

boegel closed this Mar 22, 2019

boegel reopened this Mar 22, 2019

easybuilders deleted a comment from boegelbot Mar 22, 2019

ocaisa merged commit d49d7a6 into easybuilders:develop Mar 22, 2019

boegel deleted the fix_log_path_templates branch March 22, 2019 14:38

Provide feedback