Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add 'change_into_dir' named argument to 'extract_file' + print deprecation warning if it's not specified #3292

Merged
merged 4 commits into from
May 1, 2020
Merged

add 'change_into_dir' named argument to 'extract_file' + print deprecation warning if it's not specified #3292

merged 4 commits into from
May 1, 2020

Conversation

boegel
Copy link
Member

@boegel boegel commented Apr 19, 2020

cfr. 2858

If this gets merged, we'll need to make all calls to extract_file in easyblocks also specify change_into_dir...

@boegel boegel added the change label Apr 19, 2020
@boegel boegel added this to the next release (4.2.1?) milestone Apr 19, 2020
akesandgren
akesandgren approved these changes May 1, 2020
View reviewed changes
Copy link
Contributor

@akesandgren akesandgren left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but where does all the complaints come from?

akesandgren
akesandgren requested changes May 1, 2020
View reviewed changes
easybuild/tools/filetools.py Show resolved Hide resolved
easybuild/tools/filetools.py Show resolved Hide resolved
@easybuilders easybuilders deleted a comment from boegelbot May 1, 2020
@boegel boegel mentioned this pull request May 1, 2020
Merged
@boegel
Copy link
Member Author

boegel commented May 1, 2020

@akesandgren easyblocks fixed in easybuilders/easybuild-easyblocks#2051

@akesandgren
Copy link
Contributor

Going in, thanks @boegel!

@akesandgren akesandgren merged commit f0164b5 into easybuilders:develop May 1, 2020
@boegel boegel deleted the extract_file_chdir branch May 1, 2020 15:48
@boegel boegel mentioned this pull request May 1, 2020
Merged
@boegel boegel mentioned this pull request May 19, 2020
Closed
@boegel boegel mentioned this pull request Oct 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akesandgren akesandgren akesandgren approved these changes

Assignees
No one assigned
Labels
change
Projects
None yet
Milestone
4.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@boegel @akesandgren