Fix problems with CrayCCE processing when there are no actual external modules #3319
Conversation
…l modules. Set name and version for EXTERNAL_MODULES which lacks an actual module in _parse_dependency. And since craympich.py doesn't have an separate MPI module, MPI_MODULE_NAME should be None and not an empty list.
akesandgren
changed the title
…do not set the dependency name/version
There was a problem hiding this comment.
@akesandgren The fixes done here should be covered by the tests too, otherwise we're doomed to reintroduce similar issues again...
|
Yeah, this was mainly a proof-of-concept, figuring out what things where causing problems. |
|
I'm working on an enhanced test for |
|
@akesandgren The enhanced test in akesandgren#16 triggers the problem with The current changes fix the issue with We should probably get rid of all those deprecation warnings in the output of |
enhance test for --list-software and --list-installed-software to catch bug reported in easybuilders#3265
…name/version in case no metadata is available for external modules
| if len(name_version) > 1: | ||
| dependency['version'] = name_version[1] | ||
| else: | ||
| dependency['version'] = '' |
There was a problem hiding this comment.
@akesandgren This is still quite hacky, and will have unintended side effects.
We better make HierarchicalMNS compatible with Cray toolchains, where there is no info available on the toolchain compiler (since there's no dedicated toolchain component for it), see akesandgren#17
…xtensions + enhance test_hierarchical_mns
make HierarhicalMNS compatible with Cray toolchains
fix broken test_index_functions
akesandgren
changed the title
Make HMNS compatible with Cray toolchains
And since craympich.py doesn't have an separate MPI module,
MPI_MODULE_NAME should be None and not an empty list.
Fixes #3265