Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check easyconfig itself as well as deps for versionsuffix when using --try-update-deps #3330

Merged
merged 1 commit into from
May 8, 2020

Conversation

ocaisa
Copy link
Member

@ocaisa ocaisa commented May 8, 2020

This is required as we may need to use the versionsuffix mapping for the easyconfig versionsuffix.

Fix bug introduced by #3326:

alanc@~$ eb --experimental --dry-run --robot --try-toolchain=foss,2019a --minimal-toolchains --try-update-deps --try-software-version=2.2.5 Keras-2.2.4-foss-2018b-Python-3.6.6.eb
== temporary log file in case of crash /tmp/eb-omkGKx/easybuild-rhrl3H.log
ERROR: Failed to process easyconfig /tmp/eb-omkGKx/tweaked_easyconfigs/Keras-2.2.5-foss-2019a-Python-3.7.2.eb: Failed to determine minimal toolchain for dep Theano 1.0.3-Python-3.7.2

This was due to the filename of Theano not being correct when writing the tweaked easyconfig.

@boegel boegel added the bug fix label May 8, 2020
@boegel boegel added this to the next release (4.2.1?) milestone May 8, 2020
@ocaisa ocaisa changed the title Fix bug introduced by #3326 Check if easyconfig itself as well as deps for versionsuffix... May 8, 2020
@ocaisa ocaisa changed the title Check if easyconfig itself as well as deps for versionsuffix... Check easyconfig itself as well as deps for versionsuffix... May 8, 2020
@ocaisa
Copy link
Member Author

ocaisa commented May 8, 2020

@mboisson Can you check that the problem you were trying to avoid is still avoided with this fix?

@mboisson
Copy link
Contributor

mboisson commented May 8, 2020

I don't have much time today to test this, but reading the code, I don't see how it could break. And it makes sense to keep checking versionsuffix if the recipe you are trying to build includes such

@boegel boegel changed the title Check easyconfig itself as well as deps for versionsuffix... check easyconfig itself as well as deps for versionsuffix when using --try-update-deps May 8, 2020
@boegel boegel merged commit a8d397d into easybuilders:develop May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants