Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate --accept-eula, rename to --accept-eula-for + also accept regular expression value #3630

Merged
merged 2 commits into from
Apr 5, 2021
Merged

deprecate --accept-eula, rename to --accept-eula-for + also accept regular expression value #3630

merged 2 commits into from
Apr 5, 2021

Conversation

boegel
Copy link
Member

@boegel boegel commented Apr 5, 2021

fixes #3595

@boegel boegel added this to the next release (4.3.4?) milestone Apr 5, 2021
Micket
Micket approved these changes Apr 5, 2021
View reviewed changes
Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket merged commit 89ca410 into easybuilders:develop Apr 5, 2021
@boegel boegel deleted the accept_eula_for branch April 5, 2021 20:40
@boegel boegel mentioned this pull request Apr 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Micket Micket Micket approved these changes

Assignees
No one assigned
Labels
change enhancement
Projects
None yet
Milestone
4.3.4
Development

Successfully merging this pull request may close these issues.

Misleading --accept-eula configuration option and a wildcard proposal
2 participants
@boegel @Micket