extend list of valid modules classes #368
Conversation
|
I suggest we don't hard code these checks in framework/config.py but allow them to be specified in the configuration file? This seems to be the only long term/flexible way to do this. |
|
That's right, see #209. However, we also should have a reasonable default, and allow to use module classes like This pull request is a first attempt to have a reasonable default, that can be easily overridden once #209 is fixed. |
|
Well, either fix bulletpoint 1 of #209 here, (the list of valid module classes is now hard coded; one should be able to extend these in easybuild_config.py ) But the hardcoded list should be removed here, not patched. |
|
And then just define the default list of module classes in the default EasyBuild configuration file? |
|
Yes, people might want to change the default to fit their own liking anyway.. |
|
Sounds good, that's indeed a better solution. I'll fix it, and let you know when it's ready to be reviewed. |
|
Fixed @JensTimmerman's remarks, module classes can now be easily customized via the EasyBuild configuration file. This pull request should now solve the following issues:
Please review, so I can merge this in. |
|
Ok |
extend list of valid modules classes
The issue was caused by self.show returning stdout and stderr As it now returns only stderr the issue is no longer possible
The issue was caused by self.show returning stdout and stderr As it now returns only stderr the issue is no longer possible
The issue was caused by self.show returning stdout and stderr As it now returns only stderr the issue is no longer possible
The issue was caused by self.show returning stdout and stderr As it now returns only stderr the issue is no longer possible
On request of @fgeorgatos, extend the list of valid module classes.
This may need to be extended in the future, but for now, it should be sufficient, and the entries that are there make sense and will/should stay there in the future (this is important, e.g. to keep compatibility with old easyconfig files).