Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pick up custom extract_cmd specified for extension #3907

Merged
merged 2 commits into from
Dec 4, 2021

Conversation

boegel
Copy link
Member

@boegel boegel commented Nov 30, 2021

No description provided.

@boegel boegel added the bug fix label Nov 30, 2021
@boegel boegel added this to the next release (4.5.1?) milestone Nov 30, 2021
@boegel boegel requested a review from smoors November 30, 2021 16:40
test/framework/toy_build.py Outdated Show resolved Hide resolved
…rify behaviour of find_extension in extract_cmd, extend test_extract_cmd to check case of unknown extension
@boegel boegel requested a review from smoors December 4, 2021 14:01
@smoors
Copy link
Contributor

smoors commented Dec 4, 2021

tested with a custom PythonBundle easyconfig, and works as expected.

Copy link
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Contributor

smoors commented Dec 4, 2021

Going in, thanks @boegel!

@smoors smoors merged commit f1f421b into easybuilders:develop Dec 4, 2021
@boegel boegel deleted the ext_extract_cmd branch December 4, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants