-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch to using pip3 for installing EasyBuild in container recipes generated by EasyBuild #3945
Conversation
@scimerman The CI was failing because a test needed to be updated to reflect this change, hopefully should be fixed now. |
I had a feeling, as test it was expecting a line with "pip ..." instead "pip3 ...". I am holding my fingers crossed :) |
@scimerman Can you please merge scimerman#1 (which should fix the tests again) |
While we are doing this I wanted to actually see if I can fix the Docker recipes as well |
Also update docker container recipes
👍 done |
@scimerman Another PR to merge here (fixes Docker support) scimerman#2 |
For posterity, to check the Docker images I ran:
and verified that I could get a shell inside the containers with the module pre-loaded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once scimerman#2 is merged this should be good to go...but I am no longer the one who should merge it since a lot of the commits are now mine...@boegel?
Update Docker support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for the work on this @scimerman and @ocaisa!
I've opened #3958 to catch the problems being fixed here in CI, so we at least know when it's broken through the test suite...
This is a solution for currently not working python2 pip problem. The problem happens when created definition file is being build, and it fails at the stage of updating pip. The update for pip on python 2 is failing with error, and the singularity sif file is not produced.
I do not see the reason why the container should even need to use the python 2. The support for python2 pip is expected to get even worse in the future.
The error was reported: #3956
The users are currently either 1) creating the singularity definiton file, manually updating it, and then build with singulairty, 2) updating the template and then linking the creation of singularity definition on that one OR 3) not able to use this functionality.
I have checked and the current "[packagemanager] install python-pip" and "python" can be easily replaced with "[packagemanager] install python3-pip" and python3. I have checked, and the packages python3-pip and python3 exists on the ubuntu, centos/redhat/fedora and sles linux environments.
edit: fixes #3956