add end-to-end test for running EasyBuild in different Linux distros using containers #3968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lexming
previously requested changes
Mar 1, 2022
…w for testing EasyBuild
boegel
commented
Mar 2, 2022
.github/workflows/end2end.yml
Outdated
| fi | ||
|
|
||
| # tests are run with root privileges, so we need to tell EasyBuild that's OK... | ||
| export EASYBUILD_ALLOW_USE_AS_ROOT_AND_ACCEPT_CONSEQUENCES=1 |
There was a problem hiding this comment.
We should add an easybuild user in the container image to avoid having to use root
There was a problem hiding this comment.
Fixing this required sudo to be in the container images, see easybuilders/easybuild-containers#23
|
I did some extra work on this in a separate branch (see https://github.com/boegel/easybuild-framework/tree/end2test_test_TEST_TEST), but tests are acting up there, and it's not entirely clear to me why... I'll get back to this later, this shouldn't block the release of EasyBuild v4.5.4... |
SebastianAchilles
approved these changes
Aug 25, 2023
SebastianAchilles
dismissed
lexming’s stale review
Requested changes have been implemented.
|
Going in, thanks @boegel! |
1 similar comment
|
Going in, thanks @boegel! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.