Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

take into account custom configuration options specified in easystack file + drop support for easystack files using 'software' top-level key #4057

Merged
merged 57 commits into from
Nov 23, 2022
Merged

take into account custom configuration options specified in easystack file + drop support for easystack files using 'software' top-level key #4057

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
05b3873
Allow reconfiguring. Then, in main, loop over items in the EasyStack …
casparvl Aug 10, 2022
bbd3630
Added support for merging command line arguments and easyconfig speci…
casparvl Sep 15, 2022
88a501d
cleaned up logging, removed unnecessary functions that aren't used in…
casparvl Sep 16, 2022
48ce5b3
Fixing too long lines etc
casparvl Sep 16, 2022
245cee3
Trailing whitespace removed
casparvl Sep 16, 2022
b4c4b8a
More cleanup of too long lines, added additional arg to rest_of_main.…
casparvl Sep 19, 2022
5b908a4
Shortened line
casparvl Sep 19, 2022
3264068
Remove the todo to clean the singleton, this is done now in set_up_co…
casparvl Sep 19, 2022
3c0252e
Move install_latest_eb_release logic to the top of 'rest_of_main', th…
casparvl Oct 12, 2022
8afef99
Get rid of skip_clean_exit. Just always return from rest_of_main wher…
casparvl Oct 12, 2022
81c46fb
Merge branch 'easybuilders:develop' into easystack_options_support
casparvl Oct 12, 2022
ba76b54
Make hound happy
casparvl Oct 12, 2022
e107a4b
Renamed rest_of_main to process_eb_args. Fixed some more hound stuff
casparvl Oct 12, 2022
d129859
Also clear ConfigurationVariables singleton. Furthermore, cleanup the…
casparvl Oct 12, 2022
523e47e
Inline unroll_arguments again, as it used to be. It is only used once…
casparvl Oct 12, 2022
819138d
Clear easyconfigs caches in between loop iterations over items in eas…
casparvl Oct 12, 2022
d3f4ac3
Fix identiation and forgotten bracket
casparvl Oct 12, 2022
a656eaa
Fixed missing import and typo
casparvl Oct 12, 2022
d98aa46
Removed debugging print
casparvl Oct 12, 2022
5096c4c
Seperated out processing of the EasyStack file into a single function…
casparvl Oct 12, 2022
63f9a3d
Warn against using EasyStack combined with normal command line argume…
casparvl Oct 12, 2022
b11f346
add test for test_set_up_configuration
boegel Oct 12, 2022
933f949
rename dict_to_argslist to opts_dict_to_eb_opts + make it more robust…
boegel Oct 12, 2022
7256156
add end-to-end test for easystack file with easyconfig-specific options
boegel Oct 12, 2022
a82ef48
fix indent in main.py + fix syntax error with Python 2.7
boegel Oct 13, 2022
c8d3759
use cleanup rather than clean_exit at the end of main function
boegel Oct 13, 2022
03b7755
also pass down EasyBuildOptions into process_eb_args
boegel Oct 13, 2022
046f581
only pass down EasyBuildOptions into process_eb_args
boegel Oct 13, 2022
863641c
move determining of easyconfigs_pkg_paths into process_eb_args + avoi…
boegel Oct 13, 2022
6cbdd55
Merge branch 'develop' into easystack_options_support
boegel Oct 21, 2022
d5a8071
specify that _log is a global variable in process_eb_args + process_e…
boegel Oct 21, 2022
8174f06
take into account that test suite may be configured to run with 'Tcl'…
boegel Oct 21, 2022
73ab067
drop support for easystack files that use 'software' are top-level ke…
boegel Oct 21, 2022
60c511e
Removed tests that rely on software-key based EasyStack files
casparvl Oct 21, 2022
3d02f31
Removed versions test, which was specific to EasyStacks with software…
casparvl Oct 21, 2022
cd8bb71
Added tests for easystack formats that forget the '-' when listing ea…
casparvl Oct 21, 2022
14c9ba1
Need to decide if the format in test_easystack_basic_dict.yaml is val…
casparvl Oct 21, 2022
7e2e6d6
Changed parsing to no longer build a seperate list of easyconfig name…
casparvl Oct 21, 2022
b4cc78b
proper debug logging of parsed easystack
boegel Oct 21, 2022
544de8c
code style fixes in process_easystack
boegel Oct 21, 2022
63a879d
return full EasyStack instance in parse_easystack
boegel Oct 21, 2022
a5ce7d2
fix test_easystack_basic_dict
boegel Oct 21, 2022
664ed09
fix easystack tests
boegel Oct 21, 2022
761c365
fix iterations in test_easystack_basic
boegel Oct 21, 2022
fe59b10
make sure only 'options' key is used in EasyStackParser.parse_by_easy…
boegel Oct 21, 2022
d207013
fix typo
boegel Oct 21, 2022
b0f856f
Silence the notification about the temporary log when reconfiguring
casparvl Oct 21, 2022
fbd61e7
sort keys in Error
casparvl Oct 21, 2022
40ef1ba
Added tests to check failures when invalid keys are specified
casparvl Oct 21, 2022
ec4f0fd
Added test with EasyConfig file htat is missing easyconfigs top level…
casparvl Oct 21, 2022
e2fbdd2
Added test with EasyConfig file that is missing easyconfigs top level…
casparvl Oct 21, 2022
292498f
add test for processing an easystack file that relies on wiping of ea…
boegel Oct 21, 2022
dfcb2e2
remove unused import of det_full_ec_version in framework/easystack.py…
boegel Oct 21, 2022
0f24784
Merge branch 'develop' into easystack_options_support
boegel Nov 23, 2022
fb36aa2
Merge branch 'develop' into easystack_options_support
boegel Nov 23, 2022
b93dd22
use more YAML-like syntax for options in test easystack file
boegel Nov 23, 2022
f4f486d
sort keys in easystack parser error to avoid failing test due to rand…
boegel Nov 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading