Don't ignore modules tool when using --fetch
#4299
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The modules tool is required when resolving (at least) external dependencies.
Fixes #4298
I guess the intention was to ignore installed modules for
--fetch
as I had to change the condition forkeep_available_modules
for the test to pass as it would otherwise not fetch for installed modules which I'd guess is not intended.For that I also changed the
keep_available_modules = keep_available_modules or ...
style toany([...])
which I think is easier to read and format. The 2 dry-run and inject-checksum options are on the same line on purpose