Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't ignore modules tool when using --fetch #4299

Closed
wants to merge 1 commit into from

Conversation

Flamefire
Copy link
Contributor

The modules tool is required when resolving (at least) external dependencies.

Fixes #4298

I guess the intention was to ignore installed modules for --fetch as I had to change the condition for keep_available_modules for the test to pass as it would otherwise not fetch for installed modules which I'd guess is not intended.

For that I also changed the keep_available_modules = keep_available_modules or ... style to any([...]) which I think is easier to read and format. The 2 dry-run and inject-checksum options are on the same line on purpose

The modules tool is required when resolving (at least) external dependencies.

Fixes easybuilders#4298
@boegel boegel added the change label Aug 2, 2023
@boegel boegel added this to the 4.x milestone Aug 2, 2023
@boegel
Copy link
Member

boegel commented Aug 2, 2023

The intention of ignoring the modules tool is that --fetch can be used even if no modules tool is available at all (for example on your laptop), see also the original implementation in #2457

@Flamefire
Copy link
Contributor Author

I implemented an alternative in #4308 with the approach I described in #4298 (comment)

@boegel boegel closed this in #4308 Aug 11, 2023
@boegel boegel modified the milestones: 4.x, next release (4.8.1?) Aug 11, 2023
@Flamefire Flamefire deleted the modules-tool-fetch branch August 11, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NotImplementedError on --fetch with external_module used in easyconfig
2 participants