Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test_add_and_remove_module_path by replacing string comparison of paths by checking whether they point to the same path (since symlinks may cause trouble) #4312

Merged

Conversation

boegel
Copy link
Member

@boegel boegel commented Aug 6, 2023

No description provided.

… paths by checking whether they point to the same path (since symlinks may cause trouble)
@boegel boegel added this to the next release (4.8.1?) milestone Aug 6, 2023
@boegel boegel requested a review from ocaisa August 6, 2023 19:17
Copy link
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ocaisa ocaisa merged commit b8c153d into easybuilders:develop Aug 7, 2023
@boegel boegel deleted the fix_test_add_and_remove_module_path branch August 7, 2023 19:50
@boegel boegel changed the title fix test_add_and_remove_module_path by replacing string comparison onf paths by checking whether they point to the same path (since symlinks may cause trouble) fix test_add_and_remove_module_path by replacing string comparison of paths by checking whether they point to the same path (since symlinks may cause trouble) Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants