-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement hooks for failure scenarios: crash_hook
, cancel_hook
, fail_hook
#4315
Merged
boegel
merged 34 commits into
easybuilders:develop
from
XavierCS-dev:4302_failure_hooks
Aug 11, 2023
Merged
Implement hooks for failure scenarios: crash_hook
, cancel_hook
, fail_hook
#4315
boegel
merged 34 commits into
easybuilders:develop
from
XavierCS-dev:4302_failure_hooks
Aug 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boegel
previously approved these changes
Aug 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Some merge conflicts will pop up here if #4304 gets merged first... |
branfosj
reviewed
Aug 9, 2023
boegel
requested changes
Aug 9, 2023
XavierCS-dev
force-pushed
the
4302_failure_hooks
branch
from
August 10, 2023 13:02
e78e4d0
to
8a474bb
Compare
boegel
requested changes
Aug 10, 2023
boegel
requested changes
Aug 10, 2023
boegel
requested changes
Aug 10, 2023
boegel
requested changes
Aug 11, 2023
Co-authored-by: Simon Branford <4967+branfosj@users.noreply.github.com>
clean up passing of data produced by prepare_main into main
boegel
approved these changes
Aug 11, 2023
boegel
changed the title
Implement hooks for failure scenarios
Implement hooks for failure scenarios: Aug 15, 2023
crash_hook
, cancel_hook
, fail_hook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements 3 hooks for failure scenarios:
fail_hook
: occurs when anEasybuildError
is encountered.cancel_hook
: occurs when the user issues a keyboard interrupt.crash_hook
: occurs when a generic pythonException
is encountered.These hooks can provide external information on which errors occurred, so users taking advantage of hooks can take automated action based on which error occurred. These hooks can also be used to export the errors to external tools.
fixes #4302